From 40a3e562b01de2827fa6c2c5fd9d46631f91dc36 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Mon, 25 Mar 2019 09:05:47 +0100 Subject: Cleanup: provide printGPSCoords in C and C++ versions printGPSCoords() returned a newly allocated C-style string. Most callers simply made a QString out of it and freed the C-style string. This is paradoxical, as printGPSCoords internally works with QStrings and converts them to C-style on return. Therefore, let printGPSCoords() return a QString and create a printGPSCoordsC() wrapper for the two C-callers. Signed-off-by: Berthold Stoeger --- core/gpslocation.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'core/gpslocation.cpp') diff --git a/core/gpslocation.cpp b/core/gpslocation.cpp index d0bbcdc8f..e0b176f58 100644 --- a/core/gpslocation.cpp +++ b/core/gpslocation.cpp @@ -137,9 +137,7 @@ QString GpsLocation::currentPosition() if (delta < 300) { // we can simply use the last position that we tracked gpsTracker gt = m_trackers.last(); - char *gps = printGPSCoords(>.location); - QString gpsString = gps; - free(gps); + QString gpsString = printGPSCoords(>.location); qDebug() << "returning last position" << gpsString; return gpsString; } else { -- cgit v1.2.3-70-g09d2