From ffc3e598faa5d986d78e9a275c48193a3a835cfe Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Mon, 27 Apr 2020 21:12:24 +0200 Subject: core: create fake cylinder at end of cylinder table (hack!) When we had fixed-sized cylinder arrays, the planner used the last empty cylinder for "surface air". This was not recognized by the UI as a separate cylinder, because "empty cylinder" was the sentinel for the end of the table. The conversion to dynamically sized cylinder tables broke this code: everytime the surface segment is changed, a new dummy cylinder is added, which is visible in the UI. As a very temporary stop-gap fix, emulate the old code by creating a cylinder and then setting the end-of-table to before that cylinder. This means that we have to loosen the out-of-bound checks. That's all very scary and should be removed as soon as possible. Signed-off-by: Berthold Stoeger --- core/planner.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) (limited to 'core/planner.c') diff --git a/core/planner.c b/core/planner.c index 8cadaca01..f4fb9ee80 100644 --- a/core/planner.c +++ b/core/planner.c @@ -272,7 +272,11 @@ static void create_dive_from_plan(struct diveplan *diveplan, struct dive *dive, if (dp->cylinderid != lastcylid) { /* need to insert a first sample for the new gas */ add_gas_switch_event(dive, dc, lasttime + 1, dp->cylinderid); - cyl = get_or_create_cylinder(dive, dp->cylinderid); + cyl = get_cylinder(dive, dp->cylinderid); // FIXME: This actually may get one past the last cylinder for "surface air". + if (!cyl) { + report_error("Invalid cylinder in create_dive_from_plan(): %d", dp->cylinderid); + continue; + } sample = prepare_sample(dc); sample[-1].setpoint.mbar = po2; sample->time.seconds = lasttime + 1; @@ -1070,12 +1074,12 @@ bool plan(struct deco_state *ds, struct diveplan *diveplan, struct dive *dive, i } if (prefs.surface_segment != 0) { - // Switch to an empty air cylinder for breathing air at the surface - // If no empty cylinder is found, keep using last deco gas - cylinder_t cyl = empty_cylinder; - cyl.cylinder_use = NOT_USED; - add_cylinder(&dive->cylinders, dive->cylinders.nr, cyl); - current_cylinder = dive->cylinders.nr - 1; + // Switch to an empty air cylinder for breathing air at the surface. + // FIXME: This is incredibly silly and emulates the old code when + // we had a fixed cylinder table: It uses an extra fake cylinder + // past the regular cylinder table, which is not visible to the UI. + // Fix this as soon as possible! + current_cylinder = dive->cylinders.nr; plan_add_segment(diveplan, prefs.surface_segment, 0, current_cylinder, 0, false, OC); } create_dive_from_plan(diveplan, dive, is_planner); -- cgit v1.2.3-70-g09d2