From c4c8094e32ad78dee558a80584470172f48c45b1 Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Mon, 1 Apr 2019 22:15:19 +0200 Subject: get rid of some foreach and Q_FOREACH constructs See https://www.kdab.com/goodbye-q_foreach/ This is reduced to the places where the container is const or can be made const without the need to always introduce an extra variable. Sadly qAsConst (Qt 5.7) and std::as_const (C++17) are not available in all supported setups. Also do some minor cleanups along the way. Signed-off-by: Rolf Eike Beer --- core/qthelper.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'core/qthelper.cpp') diff --git a/core/qthelper.cpp b/core/qthelper.cpp index 1a85d35a7..3738e56f2 100644 --- a/core/qthelper.cpp +++ b/core/qthelper.cpp @@ -1144,7 +1144,7 @@ QStringList imageExtensionFilters() QStringList videoExtensionFilters() { QStringList filters; - foreach (const QString &format, videoExtensionsList) + for (const QString &format: videoExtensionsList) filters.append("*" + format); return filters; } @@ -1506,9 +1506,9 @@ int parse_seabear_header(const char *filename, char **params, int pnr) parseLine = f.readLine().trimmed(); - QStringList currColumns = parseLine.split(';'); + const QStringList currColumns = parseLine.split(';'); unsigned short index = 0; - Q_FOREACH (QString columnText, currColumns) { + for (const QString &columnText: currColumns) { if (columnText == "Time") { params[pnr++] = strdup("timeField"); params[pnr++] = intdup(index++); -- cgit v1.2.3-70-g09d2