From e5dcd9fc161891a4e70364e1dcdf232590eb49c6 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sat, 17 Feb 2018 15:55:50 +0100 Subject: Cleanup: pass QString and QByteArray const-refs to qthelper functions Passing of QStrings and QByteArrays was inconsistent in qthelper.cpp. Unify to passing const-references. Passing by value is no big deal, since QString and QByteArray do copy-on-write "optimization". Nevertheless, let's keep it as consistent and effective as possible. Signed-off-by: Berthold Stoeger --- core/qthelper.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'core/qthelper.cpp') diff --git a/core/qthelper.cpp b/core/qthelper.cpp index e03f86739..cacee776b 100644 --- a/core/qthelper.cpp +++ b/core/qthelper.cpp @@ -1127,7 +1127,7 @@ void write_hashes() } } -void add_hash(const QString filename, QByteArray hash) +void add_hash(const QString &filename, const QByteArray &hash) { if (hash.isEmpty()) return; @@ -1136,7 +1136,7 @@ void add_hash(const QString filename, QByteArray hash) localFilenameOf[hash] = filename; } -QByteArray hashFile(const QString filename) +QByteArray hashFile(const QString &filename) { QCryptographicHash hash(QCryptographicHash::Sha1); QFile imagefile(filename); @@ -1164,7 +1164,7 @@ static bool haveHash(const QString &filename) return hashOf.contains(filename); } -QString localFilePath(const QString originalFilename) +QString localFilePath(const QString &originalFilename) { QMutexLocker locker(&hashOfMutex); @@ -1486,7 +1486,7 @@ QByteArray getCurrentAppState() return currentApplicationState; } -void setCurrentAppState(QByteArray state) +void setCurrentAppState(const QByteArray &state) { currentApplicationState = state; } -- cgit v1.2.3-70-g09d2