From 45ef87954669c765cb7b317384066c6eb88dc5d3 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sun, 27 Jan 2019 22:08:13 +0100 Subject: Undo: update notes field if changed by undo commands To keep the UI in a consistent state, update the notes field if it is changed by an undo command. To that purpose, add a new signal to diveListNotifier with a list of dives and a field-id as payload. Signed-off-by: Berthold Stoeger --- core/subsurface-qt/DiveListNotifier.h | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) (limited to 'core/subsurface-qt/DiveListNotifier.h') diff --git a/core/subsurface-qt/DiveListNotifier.h b/core/subsurface-qt/DiveListNotifier.h index 40343791f..5051bf73a 100644 --- a/core/subsurface-qt/DiveListNotifier.h +++ b/core/subsurface-qt/DiveListNotifier.h @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 -// The DiveListNotifier emits signals when the dive-list changes (dives/trips created/deleted/moved) +// The DiveListNotifier emits signals when the dive-list changes (dives/trips created/deleted/moved/edited) // Note that vectors are passed by reference, so this will only work for signals inside the UI thread! #ifndef DIVELISTNOTIFIER_H @@ -10,6 +10,23 @@ #include +// Dive fields that can be edited. +// Use "enum class" to not polute the global name space. +enum class DiveField { + DATETIME, + AIR_TEMP, + WATER_TEMP, + LOCATION, + DIVEMASTER, + BUDDY, + RATING, + VISIBILITY, + SUIT, + TAGS, + MODE, + NOTES, +}; + class DiveListNotifier : public QObject { Q_OBJECT signals: @@ -49,6 +66,9 @@ signals: void diveSiteDeleted(dive_site *ds, int idx); void diveSiteDiveCountChanged(dive_site *ds); void diveSiteChanged(dive_site *ds, int field); // field according to LocationInformationModel + + // Signals emitted when dives are edited. + void divesEdited(const QVector &dives, DiveField); public: // Desktop uses the QTreeView class to present the list of dives. The layout // of this class gives us a very fundamental problem, as we can not easily @@ -60,7 +80,7 @@ public: bool inCommand() const; // The following class and function are used by divelist-modifying commands - // to signalize that are in-flight. If the returned object goes out of scope, + // to signal that they are in-flight. If the returned object goes out of scope, // the command-in-flight status is reset to its previous value. Thus, the // function can be called recursively. class InCommandMarker { -- cgit v1.2.3-70-g09d2