From 1b9581369af95bdf366f08c0d00d24c315d339bb Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Wed, 14 Aug 2019 23:53:28 +0200 Subject: Mobile: move tripId from DiveObjectHelper to DiveListModel The canonical way of displaying lists in Qt is via models. Thus, return the tripId directly from the DiveListModel instead of going indirectly via a DiveObjectHelper. In the future, this will allow us to make the DiveObjectHelper value-based, as it is not generated numerous times for every list item. Signed-off-by: Berthold Stoeger --- core/subsurface-qt/DiveObjectHelper.cpp | 5 ----- 1 file changed, 5 deletions(-) (limited to 'core/subsurface-qt/DiveObjectHelper.cpp') diff --git a/core/subsurface-qt/DiveObjectHelper.cpp b/core/subsurface-qt/DiveObjectHelper.cpp index d7d92ee90..d4bcfc4e0 100644 --- a/core/subsurface-qt/DiveObjectHelper.cpp +++ b/core/subsurface-qt/DiveObjectHelper.cpp @@ -315,11 +315,6 @@ QVector DiveObjectHelper::cylinderObjects() const return res; } -QString DiveObjectHelper::tripId() const -{ - return m_dive->divetrip ? QString::number((quint64)m_dive->divetrip, 16) : QString(); -} - int DiveObjectHelper::tripNrDives() const { struct dive_trip *dt = m_dive->divetrip; -- cgit v1.2.3-70-g09d2