From 10a026b2ffd5f9271411fb8e733a3910de88761c Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Wed, 11 Nov 2020 13:50:50 -0800 Subject: filter: avoid Windows crash The scope confusion between s (the for loop variable) and s (the function argument) caused a crash in the s.split() on Windows. Signed-off-by: Dirk Hohndel --- core/filterconstraint.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'core') diff --git a/core/filterconstraint.cpp b/core/filterconstraint.cpp index 0468a935c..bcaf72460 100644 --- a/core/filterconstraint.cpp +++ b/core/filterconstraint.cpp @@ -686,8 +686,8 @@ void filter_constraint_set_stringlist(filter_constraint &c, const QString &s) return; } c.data.string_list->clear(); - for (const QString &s: s.split(",", SKIP_EMPTY)) - c.data.string_list->push_back(s.trimmed()); + for (const QString &part: s.split(",", SKIP_EMPTY)) + c.data.string_list->push_back(part.trimmed()); } void filter_constraint_set_timestamp_from(filter_constraint &c, timestamp_t from) -- cgit v1.2.3-70-g09d2