From 5a767ce9644b12e2eab5ef928ebb9673f36fcff8 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sat, 13 Jan 2018 00:00:50 +0100 Subject: Support non-https:// repositories for saving On saving to a remote git repository, the transport was set to https://, which broke saving to ssh:// repositories. Instead determine the transport from the remote url. Signed-off-by: Berthold Stoeger --- core/git-access.c | 17 ++++++++++------- core/git-access.h | 1 + core/save-git.c | 2 +- 3 files changed, 12 insertions(+), 8 deletions(-) (limited to 'core') diff --git a/core/git-access.c b/core/git-access.c index bb5acbec6..ac8778f73 100644 --- a/core/git-access.c +++ b/core/git-access.c @@ -766,18 +766,21 @@ static git_repository *create_local_repo(const char *localdir, const char *remot return cloned_repo; } -static struct git_repository *get_remote_repo(const char *localdir, const char *remote, const char *branch) +enum remote_transport url_to_remote_transport(const char *remote) { - struct stat st; - enum remote_transport rt; - /* figure out the remote transport */ if (strncmp(remote, "ssh://", 6) == 0) - rt = RT_SSH; + return RT_SSH; else if (strncmp(remote, "https://", 8) == 0) - rt = RT_HTTPS; + return RT_HTTPS; else - rt = RT_OTHER; + return RT_OTHER; +} + +static struct git_repository *get_remote_repo(const char *localdir, const char *remote, const char *branch) +{ + struct stat st; + enum remote_transport rt = url_to_remote_transport(remote); if (verbose > 1) { fprintf(stderr, "git_remote_repo: accessing %s\n", remote); diff --git a/core/git-access.h b/core/git-access.h index 6dec7a56b..77ff106a0 100644 --- a/core/git-access.h +++ b/core/git-access.h @@ -25,6 +25,7 @@ extern int do_git_save(git_repository *repo, const char *branch, const char *rem extern const char *saved_git_id; extern void clear_git_id(void); extern void set_git_id(const struct git_oid *); +extern enum remote_transport url_to_remote_transport(const char *remote); void set_git_update_cb(int(*)(const char *)); int git_storage_update_progress(const char *text); char *get_local_dir(const char *remote, const char *branch); diff --git a/core/save-git.c b/core/save-git.c index 287a8bab9..c8c9f06a4 100644 --- a/core/save-git.c +++ b/core/save-git.c @@ -1274,7 +1274,7 @@ int do_git_save(git_repository *repo, const char *branch, const char *remote, bo /* now sync the tree with the remote server */ if (remote && !prefs.git_local_only) - return sync_with_remote(repo, remote, branch, RT_HTTPS); + return sync_with_remote(repo, remote, branch, url_to_remote_transport(remote)); return 0; } -- cgit v1.2.3-70-g09d2