From 7387b10b2944c0126999a3911d6ecf705d243a8b Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Wed, 11 Mar 2020 22:21:18 +0100 Subject: cleanup: remove current_dive parameter from divesSelected signal The diveListNotifier.divesSelected() signal is used to inform the models of a selection change. It sent the current dive as a second parameter. This is redundant, because the only sender of the signal sets current_dive just before sending the signal. Remove the parameter, which appears to be an artifact. Signed-off-by: Berthold Stoeger --- core/selection.cpp | 2 +- core/subsurface-qt/divelistnotifier.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'core') diff --git a/core/selection.cpp b/core/selection.cpp index 4890f6422..2919f6486 100644 --- a/core/selection.cpp +++ b/core/selection.cpp @@ -192,7 +192,7 @@ void setSelection(const std::vector &selection, dive *currentDive) } // Send the new selection - emit diveListNotifier.divesSelected(divesToSelect, current_dive); + emit diveListNotifier.divesSelected(divesToSelect); } extern "C" void select_single_dive(dive *d) diff --git a/core/subsurface-qt/divelistnotifier.h b/core/subsurface-qt/divelistnotifier.h index fc7115a99..5ef25e832 100644 --- a/core/subsurface-qt/divelistnotifier.h +++ b/core/subsurface-qt/divelistnotifier.h @@ -94,7 +94,7 @@ signals: void tripChanged(dive_trip *trip, TripField field); // Selection changes - void divesSelected(const QVector &dives, dive *current); + void divesSelected(const QVector &dives); // Dive site signals. Add and delete events are sent per dive site and // provide an index into the global dive site table. -- cgit v1.2.3-70-g09d2