From 820d9bcd56ace31035148fcfbb2567dcf3792ac8 Mon Sep 17 00:00:00 2001 From: jan Iversen Date: Thu, 12 Dec 2019 12:57:56 +0100 Subject: core: divehare avoid race problem. Do reply->readAll() before reply-deleteLater() With UI deleteLater() seems to happen after the function exist, but with QML it causes problems. Signed-off-by: Jan Iversen --- core/uploadDiveShare.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'core') diff --git a/core/uploadDiveShare.cpp b/core/uploadDiveShare.cpp index 3d75abf9a..8d5858e00 100644 --- a/core/uploadDiveShare.cpp +++ b/core/uploadDiveShare.cpp @@ -76,12 +76,13 @@ void uploadDiveShare::updateProgressSlot(qint64 current, qint64 total) void uploadDiveShare::uploadFinishedSlot() { + QByteArray html = reply->readAll(); reply->deleteLater(); timeout.stop(); if (reply->error() != 0) { - emit uploadFinish(false, reply->errorString(), reply->readAll()); + emit uploadFinish(false, reply->errorString(), html); } else { - emit uploadFinish(true, tr("Upload successful"), reply->readAll()); + emit uploadFinish(true, tr("Upload successful"), html); } } -- cgit v1.2.3-70-g09d2