From a71afd31ee66edf45c8970dcbd6514d7c4b5e9f0 Mon Sep 17 00:00:00 2001
From: jan Iversen <jani@apache.org>
Date: Fri, 31 Aug 2018 11:57:28 +0200
Subject: core: add auto registration to qPref*

Instead of having all register calls in subsurface-helper.cpp let
qPref.cpp handle all qPref registration, since they also need to be
different

update subsurface-helper and testqml accordingly.

Signed-off-by: Jan Iversen <jani@apache.org>
---
 core/settings/qPref.cpp      | 60 +++++++++++++++++++++++++++++++++-----------
 core/settings/qPref.h        |  4 ++-
 core/settings/qPrefPrivate.h |  3 +++
 3 files changed, 52 insertions(+), 15 deletions(-)

(limited to 'core')

diff --git a/core/settings/qPref.cpp b/core/settings/qPref.cpp
index d1e3d8b23..b37024f32 100644
--- a/core/settings/qPref.cpp
+++ b/core/settings/qPref.cpp
@@ -2,6 +2,10 @@
 #include "qPref.h"
 #include "qPrefPrivate.h"
 
+#include <QQuickItem>
+#include <QQmlEngine>
+#include <QQmlContext>
+
 qPref::qPref(QObject *parent) : QObject(parent)
 {
 }
@@ -17,18 +21,46 @@ void qPref::loadSync(bool doSync)
 	if (!doSync)
 		uiLanguage(NULL);
 
-	qPrefCloudStorage::instance()->loadSync(doSync);
-	qPrefDisplay::instance()->loadSync(doSync);
-	qPrefDiveComputer::instance()->loadSync(doSync);
-	qPrefDivePlanner::instance()->loadSync(doSync);
-	// qPrefFaceook does not use disk.
-	qPrefGeneral::instance()->loadSync(doSync);
-	qPrefGeocoding::instance()->loadSync(doSync);
-	qPrefLanguage::instance()->loadSync(doSync);
-	qPrefLocationService::instance()->loadSync(doSync);
-	qPrefPartialPressureGas::instance()->loadSync(doSync);
-	qPrefProxy::instance()->loadSync(doSync);
-	qPrefTechnicalDetails::instance()->loadSync(doSync);
-	qPrefUnits::instance()->loadSync(doSync);
-	qPrefUpdateManager::instance()->loadSync(doSync);
+	// the following calls, ensures qPref* is instanciated, registred and
+	// that properties are loaded
+	qPrefCloudStorage::loadSync(doSync);
+	qPrefDisplay::loadSync(doSync);
+	qPrefDiveComputer::loadSync(doSync);
+	qPrefDivePlanner::loadSync(doSync);
+	qPrefFacebook::loadSync(doSync);
+	qPrefGeneral::loadSync(doSync);
+	qPrefGeocoding::loadSync(doSync);
+	qPrefLanguage::loadSync(doSync);
+	qPrefLocationService::loadSync(doSync);
+	qPrefPartialPressureGas::loadSync(doSync);
+	qPrefProxy::loadSync(doSync);
+	qPrefTechnicalDetails::loadSync(doSync);
+	qPrefUnits::loadSync(doSync);
+	qPrefUpdateManager::loadSync(doSync);
+}
+
+#define REGISTER_QPREF(useClass, useQML) \
+	rc = qmlRegisterType<useClass>("org.subsurfacedivelog.mobile", 1, 0, useQML); \
+	if (rc < 0) \
+		qWarning() << "ERROR: Cannot register " << useQML << ", QML will not work!!";
+
+void qPref::registerQML()
+{
+	int rc;
+
+	REGISTER_QPREF(qPref, "SsrfPrefs");
+	REGISTER_QPREF(qPrefCloudStorage, "SsrfCloudStoragePrefs");
+	REGISTER_QPREF(qPrefDisplay, "SsrfDisplayPrefs");
+	REGISTER_QPREF(qPrefDiveComputer, "SsrfDiveComputerPrefs");
+	REGISTER_QPREF(qPrefDivePlanner, "SsrfDivePlannerPrefs");
+	REGISTER_QPREF(qPrefFacebook, "SsrfFacebookPrefs");
+	REGISTER_QPREF(qPrefGeneral, "SsrfGeneralPrefs");
+	REGISTER_QPREF(qPrefGeocoding, "SsrfGeocodingPrefs");
+	REGISTER_QPREF(qPrefLanguage, "SsrfLanguagePrefs");
+	REGISTER_QPREF(qPrefLocationService, "SsrfLocationServicePrefs");
+	REGISTER_QPREF(qPrefPartialPressureGas, "SsrfPartialPressureGasPrefs");
+	REGISTER_QPREF(qPrefProxy, "SsrfProxyPrefs");
+	REGISTER_QPREF(qPrefTechnicalDetails, "SsrfTechnicalDetailsPrefs");
+	REGISTER_QPREF(qPrefUnits, "SsrfUnitPrefs");
+	REGISTER_QPREF(qPrefUpdateManager, "SsrfUpdateManagerPrefs");
 }
diff --git a/core/settings/qPref.h b/core/settings/qPref.h
index 036b3c6b2..f62a5eec4 100644
--- a/core/settings/qPref.h
+++ b/core/settings/qPref.h
@@ -35,6 +35,9 @@ public:
 	static void load() { loadSync(false); }
 	static void sync() { loadSync(true); }
 
+	// Register QML
+	void registerQML();
+
 public:
 	enum cloud_status {
 		CS_UNKNOWN,
@@ -50,5 +53,4 @@ public:
 private:
 	static void loadSync(bool doSync);
 };
-
 #endif
diff --git a/core/settings/qPrefPrivate.h b/core/settings/qPrefPrivate.h
index 95466cece..4d8aea5ce 100644
--- a/core/settings/qPrefPrivate.h
+++ b/core/settings/qPrefPrivate.h
@@ -5,9 +5,12 @@
 // Header used by all qPref<class> implementations to avoid duplicating code
 #include "core/qthelper.h"
 #include "qPref.h"
+
 #include <QObject>
+#include <QDebug>
 #include <QVariant>
 
+
 // implementation class of the interface classes
 class qPrefPrivate {
 
-- 
cgit v1.2.3-70-g09d2