From e1abf9485cf59f1b8cb79d827fa386af48f095a4 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sun, 23 Jun 2019 11:13:41 +0200 Subject: Undo: unify selection behavior in dive-list commands Some commands tried to retain the current selection on undo/redo, others set the selection to the modified dives. The latter was introduced because it was easier in some cases, but it is probably more user-friendly because the user gets feedback on the change. Therefore, unify to always select the affected dives on undo()/redo(). Signed-off-by: Berthold Stoeger --- core/subsurface-qt/DiveListNotifier.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'core') diff --git a/core/subsurface-qt/DiveListNotifier.h b/core/subsurface-qt/DiveListNotifier.h index 1d16652bd..7f97cbf8c 100644 --- a/core/subsurface-qt/DiveListNotifier.h +++ b/core/subsurface-qt/DiveListNotifier.h @@ -53,13 +53,12 @@ signals: void tripChanged(dive_trip *trip, TripField field); // Selection-signals come in two kinds: - // - divesSelected, divesDeselected and currentDiveChanged are are used by the dive-list + // - divesSelected and currentDiveChanged are are used by the dive-list // model and view to correctly highlight the correct dives. // - selectionChanged() is called once at the end of commands if either the selection // or the current dive changed. It is used by the main-window / profile to update // their data. void divesSelected(const QVector &dives); - void divesDeselected(const QVector &dives); void currentDiveChanged(); void selectionChanged(); -- cgit v1.2.3-70-g09d2