From b19adecb9f679b3b4523d679e65dedc2849d50e6 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sat, 8 Sep 2018 19:58:11 +0200 Subject: Undo: make adding of planned dive undo-able Planned dives were still added by directly calling core code. This could confuse the undo-machinery, leading to crashes. Instead, use the proper undo-command. The problem is that as opposed to the other AddDive-commands, planned dives may belong to a trip. Thus, the interface to the AddDive command was changed to respect the divetrip field. Make sure that the other callers reset that field (actually, it should never be set). Add a comment describing the perhaps surprising interface (the passed-in dive, usually displayed dive, is reset). Moreover, a dive cloned in the planner is not assigned a new number. Thus, add an argument to the AddDive-command, which expresses whether a new number should be generated for the to-be-added dive. Signed-off-by: Berthold Stoeger --- desktop-widgets/command_divelist.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'desktop-widgets/command_divelist.h') diff --git a/desktop-widgets/command_divelist.h b/desktop-widgets/command_divelist.h index 650a64ba4..29c9c6e7b 100644 --- a/desktop-widgets/command_divelist.h +++ b/desktop-widgets/command_divelist.h @@ -82,7 +82,7 @@ private: class AddDive : public DiveListBase { public: - AddDive(dive *dive, bool autogroup); + AddDive(dive *dive, bool autogroup, bool newNumber); private: void undoit() override; void redoit() override; -- cgit v1.2.3-70-g09d2