From d1572a8d9574e80955796b8667317c8dbd376081 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Wed, 28 Feb 2018 23:37:09 +0100 Subject: Cleanup: introduce copy_qstring() function strdup(qPrintable(s)) and copy_string(qPrintable(s)) were such common occurrences that they seem worthy of a short helper-function. Signed-off-by: Berthold Stoeger --- desktop-widgets/downloadfromdivecomputer.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'desktop-widgets/downloadfromdivecomputer.cpp') diff --git a/desktop-widgets/downloadfromdivecomputer.cpp b/desktop-widgets/downloadfromdivecomputer.cpp index c2bf7740e..ad8416a07 100644 --- a/desktop-widgets/downloadfromdivecomputer.cpp +++ b/desktop-widgets/downloadfromdivecomputer.cpp @@ -297,7 +297,7 @@ void DownloadFromDCWidget::on_downloadCancelRetryButton_clicked() #endif if (data->vendor() == "Uemis") { char *colon; - char *devname = strdup(qPrintable(ui.device->currentText())); + char *devname = copy_qstring(ui.device->currentText()); if ((colon = strstr(devname, ":\\ (UEMISSDA)")) != NULL) { *(colon + 2) = '\0'; @@ -362,7 +362,7 @@ void DownloadFromDCWidget::pickLogFile() filename, tr("Log files") + " (*.log)"); if (!logFile.isEmpty()) { free(logfile_name); - logfile_name = copy_string(qPrintable(logFile)); + logfile_name = copy_qstring(logFile); } } @@ -388,7 +388,7 @@ void DownloadFromDCWidget::pickDumpFile() filename, tr("Dump files") + " (*.bin)"); if (!dumpFile.isEmpty()) { free(dumpfile_name); - dumpfile_name = copy_string(qPrintable(dumpFile)); + dumpfile_name = copy_qstring(dumpFile); } } -- cgit v1.2.3-70-g09d2