From 75767c456a2889d213621866a9f7fbb108f3366d Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Fri, 10 May 2019 19:51:43 +0200 Subject: Turn application state into enum The application state was encoded in a QByteArray. Thus, there was no compile-time checking. Typos would lead to silent failures. Turn the application state into an enum. Use the enum-class construct, so that the values don't polute the global namespace. Moreover, this makes them strongly typed, i.e. they don't auto-convert to integers. A disadvantage is that the enums now have to be cast to int explicitly when used to index an array. Replace two hash-maps in MainWindow to arrays of fixed sizes. Move the application-state details into their own files. Signed-off-by: Berthold Stoeger --- desktop-widgets/filterwidget2.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'desktop-widgets/filterwidget2.cpp') diff --git a/desktop-widgets/filterwidget2.cpp b/desktop-widgets/filterwidget2.cpp index 622b66aa6..bbb0aa124 100644 --- a/desktop-widgets/filterwidget2.cpp +++ b/desktop-widgets/filterwidget2.cpp @@ -161,7 +161,7 @@ void FilterWidget2::clearFilter() void FilterWidget2::closeFilter() { - MainWindow::instance()->setApplicationState("Default"); + MainWindow::instance()->setApplicationState(ApplicationState::Default); } void FilterWidget2::temperatureChanged() -- cgit v1.2.3-70-g09d2