From 5e1e6110ce50b33e24667ce83ab5d2417a2a466e Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Mon, 30 Jul 2018 20:41:33 +0200 Subject: Cleanup: remove parameter from currentDiveChanged signal The currentDiveChanged signal was emitted by the DiveListView to inform the MainWindow of a change of current dive. The new current dive was passed as a parameter. The slot in MainWindow then called select_dive() on the dive. This seems pointless because: 1) In both emits, selected_dive dive was passed as argument. But MainWindow can read this global variable itself. 2) Calling select_dive() again is a no-op, because obviously, this already *was* the selected dive. Moreover it seems conceptually wrong to set the current dive in the slot that is informed of the change of the current dive. Signed-off-by: Berthold Stoeger --- desktop-widgets/starwidget.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'desktop-widgets/starwidget.cpp') diff --git a/desktop-widgets/starwidget.cpp b/desktop-widgets/starwidget.cpp index f5ba43be8..2f72d7df0 100644 --- a/desktop-widgets/starwidget.cpp +++ b/desktop-widgets/starwidget.cpp @@ -57,7 +57,7 @@ void StarWidget::mouseReleaseEvent(QMouseEvent *event) else current = starClicked; - Q_EMIT valueChanged(current); + emit valueChanged(current); update(); } @@ -88,7 +88,7 @@ void StarWidget::setCurrentStars(int value) { current = value; update(); - Q_EMIT valueChanged(current); + emit valueChanged(current); } StarWidget::StarWidget(QWidget *parent, Qt::WindowFlags f) : QWidget(parent, f), -- cgit v1.2.3-70-g09d2