From df156a56c08a56eb380711a507ef739d8150a71f Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Tue, 31 Jul 2018 07:41:19 +0200 Subject: Cleanup: replace virtual by override where appropriate The keyword "virtual" signalizes that the function is virtual, i.e. the function of the derived class is called, even if the call is on the parent class. It is not necessary to repeat the "virtual" keyword in derived classes. To highlight derived virtual functions, the keyword "override" should be used instead. It results in a hard compile- error, if no function is overridden, thus avoiding subtle bugs. Replace "virtual" by "override" where appropriate. Moreover, replace Q_DECL_OVERRIDE by override, since we require reasonably recent compilers anyway. Likewise, replace /* reimp */ by "override" for consistency and compiler support. Signed-off-by: Berthold Stoeger --- desktop-widgets/tableview.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'desktop-widgets/tableview.h') diff --git a/desktop-widgets/tableview.h b/desktop-widgets/tableview.h index 313a474f4..5dc5db2b5 100644 --- a/desktop-widgets/tableview.h +++ b/desktop-widgets/tableview.h @@ -27,7 +27,7 @@ class TableView : public QGroupBox { }; public: TableView(QWidget *parent = 0); - virtual ~TableView(); + ~TableView(); /* The model is expected to have a 'remove' slot, that takes a QModelIndex as parameter. * It's also expected to have the column '1' as a trash icon. I most probably should create a * proxy model and add that column, will mark that as TODO. see? marked. @@ -40,8 +40,8 @@ public: QTableView *view(); protected: - virtual void showEvent(QShowEvent *); - virtual void resizeEvent(QResizeEvent *); + void showEvent(QShowEvent *) override; + void resizeEvent(QResizeEvent *) override; signals: void addButtonClicked(); -- cgit v1.2.3-70-g09d2