From 1bf76dd3db9106fe99ee2f4bae7d7ecc4766faef Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Sat, 27 Aug 2016 12:26:13 -0700 Subject: Settings update: Fix broken UpdateManger logic In commit b76c1846bbfd ("Settings update: Simplify Update Manager") the logic for when to show the UpdateManger question to the user got broken. Unintuitively, a boolean setting actually has three possible values. True, False, and Unset. This patch fixes things to work as designed again. Signed-off-by: Dirk Hohndel --- desktop-widgets/updatemanager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'desktop-widgets') diff --git a/desktop-widgets/updatemanager.cpp b/desktop-widgets/updatemanager.cpp index b56580113..603ba1b01 100644 --- a/desktop-widgets/updatemanager.cpp +++ b/desktop-widgets/updatemanager.cpp @@ -110,7 +110,7 @@ void UpdateManager::requestReceived() } if (isAutomaticCheck) { auto update_settings = SettingsObjectWrapper::instance()->update_manager_settings; - if (!update_settings->dontCheckForUpdates()) { + if (!update_settings->dontCheckExists()) { // we allow an opt out of future checks QMessageBox response(MainWindow::instance()); -- cgit v1.2.3-70-g09d2