From 468eb7ef33443dcc303aaf87e4d33302053238fa Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sun, 4 Oct 2020 21:24:01 +0200 Subject: clenup: remove bogus connect statement. In OstcFirmwareCheck::saveOstcFirmware() we find the connect() call connect(dialog, SIGNAL(finished(int)), config, SLOT(dc_close())); whereby "config" is of the type "ConfigureDiveComputer". However, the function signature of ConfigureDiveComputer::dc_close reads as void dc_close(device_data_t *data); and indeed "data" is accessed inside the function. I don't understand how this doesn't crash, but clearly something is amiss. Let's remove that connect statement. Signed-off-by: Berthold Stoeger --- desktop-widgets/configuredivecomputerdialog.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'desktop-widgets') diff --git a/desktop-widgets/configuredivecomputerdialog.cpp b/desktop-widgets/configuredivecomputerdialog.cpp index 6fd855648..d7d6fb8ba 100644 --- a/desktop-widgets/configuredivecomputerdialog.cpp +++ b/desktop-widgets/configuredivecomputerdialog.cpp @@ -347,7 +347,6 @@ void OstcFirmwareCheck::saveOstcFirmware(QNetworkReply *reply) connect(config, SIGNAL(message(QString)), dialog, SLOT(setLabelText(QString))); connect(config, SIGNAL(error(QString)), dialog, SLOT(setLabelText(QString))); connect(config, SIGNAL(progress(int)), dialog, SLOT(setValue(int))); - connect(dialog, SIGNAL(finished(int)), config, SLOT(dc_close())); config->dc_open(&devData); config->startFirmwareUpdate(storeFirmware, &devData); } -- cgit v1.2.3-70-g09d2