From 48b8129137ed3db1c4b0940301c8bfc9662bcee3 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Thu, 2 May 2019 22:41:24 +0200 Subject: Cleanup: remove MapWidgetHelper::m_selectedDiveIds member This member variable was only used locally in functions. Accordingly, make it a function-local variable. Signed-off-by: Berthold Stoeger --- desktop-widgets/mapwidget.cpp | 5 ++--- desktop-widgets/mapwidget.h | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) (limited to 'desktop-widgets') diff --git a/desktop-widgets/mapwidget.cpp b/desktop-widgets/mapwidget.cpp index bbdf89de2..14ac3a075 100644 --- a/desktop-widgets/mapwidget.cpp +++ b/desktop-widgets/mapwidget.cpp @@ -48,8 +48,7 @@ void MapWidget::doneLoading(QQuickWidget::Status status) isReady = true; m_rootItem = qobject_cast(rootObject()); m_mapHelper = rootObject()->findChild(); - connect(m_mapHelper, SIGNAL(selectedDivesChanged(QList)), - this, SLOT(selectedDivesChanged(QList))); + connect(m_mapHelper, &MapWidgetHelper::selectedDivesChanged, this, &MapWidget::selectedDivesChanged); connect(m_mapHelper, &MapWidgetHelper::coordinatesChanged, this, &MapWidget::coordinatesChanged); } @@ -108,7 +107,7 @@ void MapWidget::prepareForGetDiveCoordinates(struct dive_site *ds) skipReload = true; } -void MapWidget::selectedDivesChanged(QList list) +void MapWidget::selectedDivesChanged(const QList &list) { CHECK_IS_READY_RETURN_VOID(); skipReload = true; diff --git a/desktop-widgets/mapwidget.h b/desktop-widgets/mapwidget.h index 9d31aa75a..96da308d8 100644 --- a/desktop-widgets/mapwidget.h +++ b/desktop-widgets/mapwidget.h @@ -31,7 +31,7 @@ public slots: void endGetDiveCoordinates(); void repopulateLabels(); void prepareForGetDiveCoordinates(struct dive_site *ds); - void selectedDivesChanged(QList); + void selectedDivesChanged(const QList &); void coordinatesChanged(struct dive_site *ds, const location_t &); void doneLoading(QQuickWidget::Status status); void diveSiteChanged(struct dive_site *ds, int field); -- cgit v1.2.3-70-g09d2