From 4a61f155d3c7bfed7262884019f7bcf1f5b86376 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Thu, 25 Apr 2019 13:09:11 +0200 Subject: Cleanup: simplify DiveLocationLineEdit::showPopup() DiveLocationLineEdit::showPopup() called the functions - fixPopupPosition() - proxy->invalidate() - proxy->sort(LocationInformationModel::NAME) - view->show() All these calls are redundant, as they are already performed by setTemporaryDiveSiteName(). Remove them. Signed-off-by: Berthold Stoeger --- desktop-widgets/locationinformation.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'desktop-widgets') diff --git a/desktop-widgets/locationinformation.cpp b/desktop-widgets/locationinformation.cpp index 5872089a4..9f61459b6 100644 --- a/desktop-widgets/locationinformation.cpp +++ b/desktop-widgets/locationinformation.cpp @@ -575,13 +575,8 @@ void DiveLocationLineEdit::setCurrentDiveSite(struct dive *d) void DiveLocationLineEdit::showPopup() { - fixPopupPosition(); - if (!view->isVisible()) { + if (!view->isVisible()) setTemporaryDiveSiteName(text()); - proxy->invalidate(); - proxy->sort(LocationInformationModel::NAME); - view->show(); - } } DiveLocationLineEdit::DiveSiteType DiveLocationLineEdit::currDiveSiteType() const -- cgit v1.2.3-70-g09d2