From 8ef87e618afd1ec943c0f42a852b3b393c1e2113 Mon Sep 17 00:00:00 2001 From: Martin Měřinský Date: Wed, 29 Nov 2017 10:57:08 +0100 Subject: Use better aliases for icons. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Icon aliases were complete mess. Some icons had alias some didn't. Named with underscores vs. hyphens vs. camelCase. Lower vs. upper case. "ICON" prefix vs. suffix vs. nothing. With vs. without filename suffix. Some didn't make sence. Eg. mapwidget-marker-gray (I can see, it's grey, but what does it represent?) Some were duplicated, eg warning vs. warning-icon. Some were name after widget, which is wrong. Do not reinvent wheel. Use widely used naming scheme close to Freedesktop Icon Naming Specification. This will enable usage of common icons from current set in the future. Thus Subsurface will fit nicely to GUI. This changes icon aliases to one, easy grep-able style. Signed-off-by: Martin Měřinský --- desktop-widgets/configuredivecomputerdialog.ui | 8 ++--- desktop-widgets/filterwidget.ui | 4 +-- desktop-widgets/locationInformation.ui | 2 +- desktop-widgets/locationinformation.cpp | 4 +-- desktop-widgets/mainwindow.ui | 34 +++++++++++----------- .../preferences/preferences_defaults.cpp | 2 +- .../preferences/preferences_georeference.cpp | 2 +- desktop-widgets/preferences/preferences_graph.cpp | 2 +- .../preferences/preferences_language.cpp | 2 +- .../preferences/preferences_network.cpp | 2 +- desktop-widgets/preferences/preferences_units.cpp | 2 +- desktop-widgets/searchbar.ui | 4 +-- desktop-widgets/simplewidgets.cpp | 6 ++-- desktop-widgets/starwidget.cpp | 2 +- desktop-widgets/tab-widgets/maintab.ui | 2 +- desktop-widgets/tableview.cpp | 2 +- desktop-widgets/usermanual.cpp | 6 ++-- 17 files changed, 43 insertions(+), 43 deletions(-) (limited to 'desktop-widgets') diff --git a/desktop-widgets/configuredivecomputerdialog.ui b/desktop-widgets/configuredivecomputerdialog.ui index d647d1134..1657aaf3a 100644 --- a/desktop-widgets/configuredivecomputerdialog.ui +++ b/desktop-widgets/configuredivecomputerdialog.ui @@ -215,7 +215,7 @@ - :icons/ostc3.png:icons/ostc3.png + :dc-ostc-3-icon:dc-ostc-3-icon @@ -224,7 +224,7 @@ - :icons/suunto_vyper.png:icons/suunto_vyper.png + :dc-suunto-vyper-icon:dc-suunto-vyper-icon @@ -233,7 +233,7 @@ - :icons/ostc2n.png:icons/ostc2n.png + :dc-ostc-2n-icon:dc-ostc-2n-icon @@ -242,7 +242,7 @@ - :icons/ostc4.png:icons/ostc4.png + :dc-ostc-4-icon:dc-ostc-4-icon diff --git a/desktop-widgets/filterwidget.ui b/desktop-widgets/filterwidget.ui index 8e42019ce..7f548a931 100644 --- a/desktop-widgets/filterwidget.ui +++ b/desktop-widgets/filterwidget.ui @@ -74,7 +74,7 @@ - :filter-reset:filter-reset + :edit-clear-icon:edit-clear-icon true @@ -88,7 +88,7 @@ - :filter-hide:filter-hide + :hide-icon:hide-icon true diff --git a/desktop-widgets/locationInformation.ui b/desktop-widgets/locationInformation.ui index 9103bbc1f..fdd191d4f 100644 --- a/desktop-widgets/locationInformation.ui +++ b/desktop-widgets/locationInformation.ui @@ -166,7 +166,7 @@ - :mapwidget-marker-selected:mapwidget-marker-selected + :dive-location-marker-selected-icon:dive-location-marker-selected-icon diff --git a/desktop-widgets/locationinformation.cpp b/desktop-widgets/locationinformation.cpp index 454c4c68f..5212b0bf9 100644 --- a/desktop-widgets/locationinformation.cpp +++ b/desktop-widgets/locationinformation.cpp @@ -376,8 +376,8 @@ void DiveLocationModel::resetModel() QVariant DiveLocationModel::data(const QModelIndex &index, int role) const { - static const QIcon plusIcon(":plus"); - static const QIcon geoCode(":geocode"); + static const QIcon plusIcon(":list-add-icon"); + static const QIcon geoCode(":geotag-icon"); if (index.row() <= 1) { // two special cases. if (index.column() == UUID) { diff --git a/desktop-widgets/mainwindow.ui b/desktop-widgets/mainwindow.ui index 41cba8a5a..93f19e84e 100644 --- a/desktop-widgets/mainwindow.ui +++ b/desktop-widgets/mainwindow.ui @@ -454,7 +454,7 @@ - :icon_o2:icon_o2 + :pp-o2-icon:pp-o2-icon Toggle pO₂ graph @@ -466,7 +466,7 @@ - :icon_n2:icon_n2 + :pp-n2-icon:pp-n2-icon Toggle pN₂ graph @@ -478,7 +478,7 @@ - :icon_he:icon_he + :pp-he-icon:pp-he-icon Toggle pHe graph @@ -490,7 +490,7 @@ - :icon_ceiling_dc:icon_ceiling_dc + :ceiling-dc-icon:ceiling-dc-icon Toggle DC reported ceiling @@ -502,7 +502,7 @@ - :icon_ceiling_calculated:icon_ceiling_calculated + :ceiling-calculated-icon:ceiling-calculated-icon Toggle calculated ceiling @@ -514,7 +514,7 @@ - :icon_ceiling_alltissues:icon_ceiling_alltissues + :ceiling-tissues-icon:ceiling-tissues-icon Toggle calculating all tissues @@ -526,7 +526,7 @@ - :icon_ceiling_3m:icon_ceiling_3m + :ceiling-increments-icon:ceiling-increments-icon Toggle calculated ceiling with 3m increments @@ -538,7 +538,7 @@ - :icon_HR:icon_HR + :rate-heart-icon:rate-heart-icon Toggle heart rate @@ -550,7 +550,7 @@ - :icon_mod:icon_mod + :depth-mod-icon:depth-mod-icon Toggle MOD @@ -562,7 +562,7 @@ - :icon_ead:icon_ead + :depth-ead-icon:depth-ead-icon Toggle EAD, END, EADD @@ -574,7 +574,7 @@ - :icon_NDLTTS:icon_NDLTTS + :depth-ndl-icon:depth-ndl-icon Toggle NDL, TTS @@ -586,7 +586,7 @@ - :icon_lung:icon_lung + :rate-sac-icon:rate-sac-icon Toggle SAC rate @@ -598,7 +598,7 @@ - :ruler:ruler + :ruler-icon:ruler-icon Toggle ruler @@ -610,7 +610,7 @@ - :scale:scale + :scale-graph-icon:scale-graph-icon Scale graph @@ -622,7 +622,7 @@ - :pictures:pictures + :photo-icon:photo-icon Toggle pictures @@ -634,7 +634,7 @@ - :gaschange:gaschange + :gaschange-icon:gaschange-icon Toggle gas bar @@ -657,7 +657,7 @@ - :icon_tissue:icon_tissue + :heatmap-icon:heatmap-icon Toggle tissue heat-map diff --git a/desktop-widgets/preferences/preferences_defaults.cpp b/desktop-widgets/preferences/preferences_defaults.cpp index 0d4e83cc2..42dcae13d 100644 --- a/desktop-widgets/preferences/preferences_defaults.cpp +++ b/desktop-widgets/preferences/preferences_defaults.cpp @@ -7,7 +7,7 @@ #include -PreferencesDefaults::PreferencesDefaults(): AbstractPreferencesWidget(tr("General"), QIcon(":defaults"), 0 ), ui(new Ui::PreferencesDefaults()) +PreferencesDefaults::PreferencesDefaults(): AbstractPreferencesWidget(tr("General"), QIcon(":preferences-other-icon"), 0 ), ui(new Ui::PreferencesDefaults()) { ui->setupUi(this); } diff --git a/desktop-widgets/preferences/preferences_georeference.cpp b/desktop-widgets/preferences/preferences_georeference.cpp index 1d960d4b5..314a37c94 100644 --- a/desktop-widgets/preferences/preferences_georeference.cpp +++ b/desktop-widgets/preferences/preferences_georeference.cpp @@ -8,7 +8,7 @@ #include -PreferencesGeoreference::PreferencesGeoreference() : AbstractPreferencesWidget(tr("Georeference"), QIcon(":georeference"), 9) +PreferencesGeoreference::PreferencesGeoreference() : AbstractPreferencesWidget(tr("Georeference"), QIcon(":geotag-icon"), 9) { ui = new Ui::PreferencesGeoreference(); ui->setupUi(this); diff --git a/desktop-widgets/preferences/preferences_graph.cpp b/desktop-widgets/preferences/preferences_graph.cpp index 9f45c7db6..20e0918ab 100644 --- a/desktop-widgets/preferences/preferences_graph.cpp +++ b/desktop-widgets/preferences/preferences_graph.cpp @@ -7,7 +7,7 @@ #include "qt-models/models.h" -PreferencesGraph::PreferencesGraph() : AbstractPreferencesWidget(tr("Profile"), QIcon(":graph"), 5) +PreferencesGraph::PreferencesGraph() : AbstractPreferencesWidget(tr("Profile"), QIcon(":graph-icon"), 5) { ui = new Ui::PreferencesGraph(); ui->setupUi(this); diff --git a/desktop-widgets/preferences/preferences_language.cpp b/desktop-widgets/preferences/preferences_language.cpp index def46a0e2..687be1399 100644 --- a/desktop-widgets/preferences/preferences_language.cpp +++ b/desktop-widgets/preferences/preferences_language.cpp @@ -10,7 +10,7 @@ #include "qt-models/models.h" -PreferencesLanguage::PreferencesLanguage() : AbstractPreferencesWidget(tr("Language"), QIcon(":language"), 4) +PreferencesLanguage::PreferencesLanguage() : AbstractPreferencesWidget(tr("Language"), QIcon(":preferences-desktop-locale-icon"), 4) { ui = new Ui::PreferencesLanguage(); ui->setupUi(this); diff --git a/desktop-widgets/preferences/preferences_network.cpp b/desktop-widgets/preferences/preferences_network.cpp index 6ccf97384..9ea78f50b 100644 --- a/desktop-widgets/preferences/preferences_network.cpp +++ b/desktop-widgets/preferences/preferences_network.cpp @@ -8,7 +8,7 @@ #include "core/subsurface-qt/SettingsObjectWrapper.h" #include -PreferencesNetwork::PreferencesNetwork() : AbstractPreferencesWidget(tr("Network"),QIcon(":network"), 9), ui(new Ui::PreferencesNetwork()) +PreferencesNetwork::PreferencesNetwork() : AbstractPreferencesWidget(tr("Network"),QIcon(":preferences-system-network-icon"), 9), ui(new Ui::PreferencesNetwork()) { ui->setupUi(this); diff --git a/desktop-widgets/preferences/preferences_units.cpp b/desktop-widgets/preferences/preferences_units.cpp index 2ff09f192..5ae03fba2 100644 --- a/desktop-widgets/preferences/preferences_units.cpp +++ b/desktop-widgets/preferences/preferences_units.cpp @@ -5,7 +5,7 @@ #include "core/qthelper.h" #include "core/subsurface-qt/SettingsObjectWrapper.h" -PreferencesUnits::PreferencesUnits(): AbstractPreferencesWidget(tr("Units"),QIcon(":units"),1), ui(new Ui::PreferencesUnits()) +PreferencesUnits::PreferencesUnits(): AbstractPreferencesWidget(tr("Units"),QIcon(":units-icon"),1), ui(new Ui::PreferencesUnits()) { ui->setupUi(this); } diff --git a/desktop-widgets/searchbar.ui b/desktop-widgets/searchbar.ui index 22bce39c6..3acd0aab3 100644 --- a/desktop-widgets/searchbar.ui +++ b/desktop-widgets/searchbar.ui @@ -73,7 +73,7 @@ - + @@ -97,7 +97,7 @@ - + diff --git a/desktop-widgets/simplewidgets.cpp b/desktop-widgets/simplewidgets.cpp index 457589dde..fbc0a941d 100644 --- a/desktop-widgets/simplewidgets.cpp +++ b/desktop-widgets/simplewidgets.cpp @@ -30,13 +30,13 @@ public: MinMaxAvgWidgetPrivate(MinMaxAvgWidget *owner) { avgIco = new QLabel(owner); - avgIco->setPixmap(QIcon(":average").pixmap(16, 16)); + avgIco->setPixmap(QIcon(":value-average-icon").pixmap(16, 16)); avgIco->setToolTip(QObject::tr("Average")); minIco = new QLabel(owner); - minIco->setPixmap(QIcon(":minimum").pixmap(16, 16)); + minIco->setPixmap(QIcon(":value-minimum-icon").pixmap(16, 16)); minIco->setToolTip(QObject::tr("Minimum")); maxIco = new QLabel(owner); - maxIco->setPixmap(QIcon(":maximum").pixmap(16, 16)); + maxIco->setPixmap(QIcon(":value-maximum-icon").pixmap(16, 16)); maxIco->setToolTip(QObject::tr("Maximum")); avgValue = new QLabel(owner); minValue = new QLabel(owner); diff --git a/desktop-widgets/starwidget.cpp b/desktop-widgets/starwidget.cpp index 503b094ad..6f65a33a3 100644 --- a/desktop-widgets/starwidget.cpp +++ b/desktop-widgets/starwidget.cpp @@ -99,7 +99,7 @@ StarWidget::StarWidget(QWidget *parent, Qt::WindowFlags f) : QWidget(parent, f), int dim = defaultIconMetrics().sz_small; if (activeStar.isNull()) { - QSvgRenderer render(QString(":star")); + QSvgRenderer render(QString(":star-icon")); QPixmap renderedStar(dim, dim); renderedStar.fill(Qt::transparent); diff --git a/desktop-widgets/tab-widgets/maintab.ui b/desktop-widgets/tab-widgets/maintab.ui index 6fa611153..7a1be9aed 100644 --- a/desktop-widgets/tab-widgets/maintab.ui +++ b/desktop-widgets/tab-widgets/maintab.ui @@ -226,7 +226,7 @@ - :geocode:geocode + :geotag-icon:geotag-icon diff --git a/desktop-widgets/tableview.cpp b/desktop-widgets/tableview.cpp index 29ccbdbd3..560f98a43 100644 --- a/desktop-widgets/tableview.cpp +++ b/desktop-widgets/tableview.cpp @@ -43,7 +43,7 @@ TableView::TableView(QWidget *parent) : QGroupBox(parent) } layout()->setContentsMargins(margins); - QIcon plusIcon(":plus"); + QIcon plusIcon(":list-add-icon"); plusBtn = new QPushButton(plusIcon, QString(), this); plusBtn->setFlat(true); diff --git a/desktop-widgets/usermanual.cpp b/desktop-widgets/usermanual.cpp index 580dadcfd..69000dd54 100644 --- a/desktop-widgets/usermanual.cpp +++ b/desktop-widgets/usermanual.cpp @@ -11,9 +11,9 @@ SearchBar::SearchBar(QWidget *parent): QWidget(parent) { ui.setupUi(this); #if defined(Q_OS_MAC) || defined(Q_OS_WIN) - ui.findNext->setIcon(QIcon(":icons/subsurface/32x32/actions/go-down.png")); - ui.findPrev->setIcon(QIcon(":icons/subsurface/32x32/actions/go-up.png")); - ui.findClose->setIcon(QIcon(":icons/subsurface/32x32/actions/window-close.png")); + ui.findNext->setIcon(QIcon(":go-down-icon")); + ui.findPrev->setIcon(QIcon(":go-up-icon")); + ui.findClose->setIcon(QIcon(":window-close-icon")); #endif connect(ui.findNext, SIGNAL(pressed()), this, SIGNAL(searchNext())); -- cgit v1.2.3-70-g09d2