From 4ec62441c172958156e36013f9dbf71e18a51dd1 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Tue, 14 Jul 2020 10:25:46 -0700 Subject: mobile/download: don't allow download without connection set It appears that multi line attributes silently fail. Without this change, the Download button is enabled if vendor and product are chosen, even if there isn't a connection selected. With this change (having all three conditions on the same line) the code works as expected. Signed-off-by: Dirk Hohndel --- mobile-widgets/qml/DownloadFromDiveComputer.qml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'mobile-widgets/qml') diff --git a/mobile-widgets/qml/DownloadFromDiveComputer.qml b/mobile-widgets/qml/DownloadFromDiveComputer.qml index 314b887d0..012829b76 100644 --- a/mobile-widgets/qml/DownloadFromDiveComputer.qml +++ b/mobile-widgets/qml/DownloadFromDiveComputer.qml @@ -320,8 +320,7 @@ Kirigami.Page { TemplateButton { id: download text: qsTr("Download") - enabled: comboVendor.currentIndex != -1 && comboProduct.currentIndex != -1 && - comboConnection.currentIndex != -1 + enabled: comboVendor.currentIndex != -1 && comboProduct.currentIndex != -1 && comboConnection.currentIndex != -1 onClicked: { text = qsTr("Retry") -- cgit v1.2.3-70-g09d2