From 9e369688811563c77b5152a41c0ddc615abf9b74 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Sat, 15 Feb 2020 11:45:19 -0800 Subject: mobile/export: don't allow file based exports on Android There is no native file dialog, access to the file system is highly restricted and will be much more so in Android 11. Let's not even start with this. This should never have been merged as it was. Signed-off-by: Dirk Hohndel --- mobile-widgets/qml/Export.qml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'mobile-widgets/qml') diff --git a/mobile-widgets/qml/Export.qml b/mobile-widgets/qml/Export.qml index 2b1b004ab..c75a02a94 100644 --- a/mobile-widgets/qml/Export.qml +++ b/mobile-widgets/qml/Export.qml @@ -114,6 +114,10 @@ Kirigami.ScrollablePage { } } + // given that there is no native file dialog on Android and that access to + // the file system is increasingly restrictive in future versions, file based + // export really doesn't make sense on Android + ColumnLayout { width: parent.width spacing: 1 @@ -123,6 +127,7 @@ Kirigami.ScrollablePage { RadioButton { Layout.fillWidth: true text: qsTr("Export Subsurface XML") + visible: Qt.platform.os !== "android" checked: true exclusiveGroup: radioGroup onClicked: { @@ -133,6 +138,7 @@ Kirigami.ScrollablePage { RadioButton { Layout.fillWidth: true text: qsTr("Export Subsurface dive sites XML") + visible: Qt.platform.os !== "android" exclusiveGroup: radioGroup onClicked: { selectedExport = ExportType.EX_DIVE_SITES_XML @@ -142,6 +148,7 @@ Kirigami.ScrollablePage { RadioButton { Layout.fillWidth: true text: qsTr("Export UDDF") + visible: Qt.platform.os !== "android" exclusiveGroup: radioGroup onClicked: { selectedExport = ExportType.EX_UDDF @@ -199,7 +206,7 @@ Kirigami.ScrollablePage { textPassword.visible = false fieldPassword.visible = false uploadDialog.open() - } else { + } else if (Qt.platform.os !== "android") { saveAsDialog.open() } } -- cgit v1.2.3-70-g09d2