From a24f0d310792d0052064c5323b235591ff56efd9 Mon Sep 17 00:00:00 2001 From: jan Iversen Date: Sun, 17 Jun 2018 16:04:51 +0200 Subject: mobile: revert e993d4f005e62c12765e2e45342ecf840476e3bf The commit secured that plotDive was not called before actually being used. However our (rather fragile) C++ qml interface did not work correctly (ony sometimes). Revert the previous commit. Signed-off-by: Jan Iversen --- mobile-widgets/qml/DiveDetailsView.qml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'mobile-widgets/qml') diff --git a/mobile-widgets/qml/DiveDetailsView.qml b/mobile-widgets/qml/DiveDetailsView.qml index 3237fe6f6..bb7a10019 100644 --- a/mobile-widgets/qml/DiveDetailsView.qml +++ b/mobile-widgets/qml/DiveDetailsView.qml @@ -217,13 +217,6 @@ Item { border.color: subsurfaceTheme.primaryColor anchors.fill: parent } - - onVisibleChanged: { - if (visible) { - qmlProfile.diveId = model.dive.id; - qmlProfile.update(); - } - } } Controls.Label { id: noProfile @@ -404,6 +397,8 @@ Item { } Component.onCompleted: { qmlProfile.setMargin(Kirigami.Units.smallSpacing) + qmlProfile.diveId = model.dive.id; + qmlProfile.update(); } } } -- cgit v1.2.3-70-g09d2