From d55ea8f8750a7952d4e9e003bef57decc513d2d4 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sat, 21 Dec 2019 20:17:05 +0100 Subject: mobile/divelist: remove showDiveIndex QML-function The currently shown dive is now controlled by the core. Signed-off-by: Berthold Stoeger Signed-off-by: Dirk Hohndel --- mobile-widgets/qml/DiveDetails.qml | 5 ----- mobile-widgets/qml/DiveDetailsEdit.qml | 1 - mobile-widgets/qml/DiveList.qml | 3 --- 3 files changed, 9 deletions(-) (limited to 'mobile-widgets/qml') diff --git a/mobile-widgets/qml/DiveDetails.qml b/mobile-widgets/qml/DiveDetails.qml index 86ca5ea63..da2b30cf7 100644 --- a/mobile-widgets/qml/DiveDetails.qml +++ b/mobile-widgets/qml/DiveDetails.qml @@ -229,11 +229,6 @@ Kirigami.Page { } } - function showDiveIndex(id) { - currentIndex = swipeModel.getIdxForId(id); - diveDetailsListView.positionViewAtIndex(currentIndex, ListView.End); - } - function endEditMode() { // if we were adding a dive, we need to remove it if (state === "add") diff --git a/mobile-widgets/qml/DiveDetailsEdit.qml b/mobile-widgets/qml/DiveDetailsEdit.qml index 9d10772e4..ceeaedaf6 100644 --- a/mobile-widgets/qml/DiveDetailsEdit.qml +++ b/mobile-widgets/qml/DiveDetailsEdit.qml @@ -137,7 +137,6 @@ Item { diveDetailsListView.currentItem.modelData.visibility = detailsEdit.visibility Qt.inputMethod.hide() // now make sure we directly show the saved dive (this may be a new dive, or it may have moved) - showDiveIndex(newIdx) clearDetailsEdit() } diff --git a/mobile-widgets/qml/DiveList.qml b/mobile-widgets/qml/DiveList.qml index 94289c6b7..a20a84f20 100644 --- a/mobile-widgets/qml/DiveList.qml +++ b/mobile-widgets/qml/DiveList.qml @@ -420,9 +420,6 @@ Kirigami.ScrollablePage { if (diveListModel) diveListModel.setActiveTrip(diveListView.currentItem.myData.tripId) - // update the diveDetails page to also show that dive - detailsWindow.showDiveIndex(idx) - // updating the index of the ListView triggers a non-linear scroll // animation that can be very slow. the fix is to stop this animation // by setting contentY to itself and then using positionViewAtIndex(). -- cgit v1.2.3-70-g09d2