From 16b31985c3245d5cb3be26f3cc0aa06bc6acb139 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Tue, 20 Jul 2021 07:45:31 +0200 Subject: cleanup: replace membuffer by membufferpp in C-code Thus, the membuffer data is automatically freed when going out of scope - one thing less to worry about. This fixes one use-after-free bug in uploadDiveLogsDE.cpp and one extremely questionable practice in divetooltipitem.cpp: The membuffer was a shared instance across all instances of the DiveToolTipItem. Remves unnecessary #include directives in files that didn't even use membuffer. Signed-off-by: Berthold Stoeger --- mobile-widgets/qmlmanager.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'mobile-widgets') diff --git a/mobile-widgets/qmlmanager.cpp b/mobile-widgets/qmlmanager.cpp index 878d4618c..d3ea320c2 100644 --- a/mobile-widgets/qmlmanager.cpp +++ b/mobile-widgets/qmlmanager.cpp @@ -34,7 +34,6 @@ #include "core/qt-gui.h" #include "core/git-access.h" #include "core/cloudstorage.h" -#include "core/membuffer.h" #include "core/downloadfromdcthread.h" #include "core/subsurfacestartup.h" // for ignore_bt flag #include "core/subsurface-string.h" -- cgit v1.2.3-70-g09d2