From 794066b2367082851858d4e0da8b6e388d2acabb Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sun, 4 Aug 2019 22:13:49 +0200 Subject: Cylinders: access cylinders with get_cylinder() Instead of accessing the cylinder table directly, use the get_cylinder() function. This gives less unwieldy expressions. But more importantly, the function does bound checking. This is crucial for now as the code hasn't be properly audited since the change to arbitrarily sized cylinder tables. Accesses of invalid cylinder indexes may lead to silent data-corruption that is sometimes not even noticed by valgrind. Returning NULL instead of an invalid pointer will make debugging much easier. Signed-off-by: Berthold Stoeger --- mobile-widgets/qmlmanager.cpp | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) (limited to 'mobile-widgets') diff --git a/mobile-widgets/qmlmanager.cpp b/mobile-widgets/qmlmanager.cpp index f14092fb1..c27e2ca23 100644 --- a/mobile-widgets/qmlmanager.cpp +++ b/mobile-widgets/qmlmanager.cpp @@ -1125,10 +1125,10 @@ void QMLManager::commitChanges(QString diveId, QString number, QString date, QSt if (state != "add" && !is_cylinder_used(d, i)) continue; - d->cylinders.cylinders[i].start.mbar = parsePressureToMbar(startpressure[j]); - d->cylinders.cylinders[i].end.mbar = parsePressureToMbar(endpressure[j]); - if (d->cylinders.cylinders[i].end.mbar > d->cylinders.cylinders[i].start.mbar) - d->cylinders.cylinders[i].end.mbar = d->cylinders.cylinders[i].start.mbar; + get_cylinder(d, i)->start.mbar = parsePressureToMbar(startpressure[j]); + get_cylinder(d, i)->end.mbar = parsePressureToMbar(endpressure[j]); + if (get_cylinder(d, i)->end.mbar > get_cylinder(d, i)->start.mbar) + get_cylinder(d, i)->end.mbar = get_cylinder(d, i)->start.mbar; j++; } @@ -1146,8 +1146,8 @@ void QMLManager::commitChanges(QString diveId, QString number, QString date, QSt he >= 0 && he <= 1000 && o2 + he <= 1000) { diveChanged = true; - d->cylinders.cylinders[i].gasmix.o2.permille = o2; - d->cylinders.cylinders[i].gasmix.he.permille = he; + get_cylinder(d, i)->gasmix.o2.permille = o2; + get_cylinder(d, i)->gasmix.he.permille = he; } j++; } @@ -1173,9 +1173,9 @@ void QMLManager::commitChanges(QString diveId, QString number, QString date, QSt break; } } - d->cylinders.cylinders[j].type.description = copy_qstring(usedCylinder[k]); - d->cylinders.cylinders[j].type.size.mliter = size; - d->cylinders.cylinders[j].type.workingpressure.mbar = wp; + get_cylinder(d, j)->type.description = copy_qstring(usedCylinder[k]); + get_cylinder(d, j)->type.size.mliter = size; + get_cylinder(d, j)->type.workingpressure.mbar = wp; k++; } } @@ -1789,8 +1789,8 @@ QStringList QMLManager::cylinderInit() const int i = 0; for_each_dive (i, d) { for (int j = 0; j < d->cylinders.nr; j++) { - if (!empty_string(d->cylinders.cylinders[j].type.description)) - cylinders << d->cylinders.cylinders[j].type.description; + if (!empty_string(get_cylinder(d, j)->type.description)) + cylinders << get_cylinder(d, j)->type.description; } } -- cgit v1.2.3-70-g09d2