From 72427adc1c063ae5de08f4d92dc79824f6227614 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Tue, 22 Dec 2020 22:32:51 +0100 Subject: profile: remove AbstractProfilePolygonItem::settingsChanged() settingsChanged() is a virtual function, which is called when the preferences dialog signals changes. In most derived classes, the function does nothing. In two classes, DiveProfileItem and DiveCalculatedTissue, it replots the item respectively changes its visibility. However, these two flags are *not* controlled by the preferences dialog. Indeed, the functions are also connected to finer-grained qPref signals. Therefore, settingsChanged() can be removed. Signed-off-by: Berthold Stoeger --- profile-widget/diveprofileitem.h | 3 --- 1 file changed, 3 deletions(-) (limited to 'profile-widget/diveprofileitem.h') diff --git a/profile-widget/diveprofileitem.h b/profile-widget/diveprofileitem.h index e66f337af..0b928514c 100644 --- a/profile-widget/diveprofileitem.h +++ b/profile-widget/diveprofileitem.h @@ -39,7 +39,6 @@ public: virtual void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0) = 0; public slots: - virtual void settingsChanged(); virtual void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()); virtual void modelDataRemoved(const QModelIndex &parent, int from, int to); void replot(); @@ -71,7 +70,6 @@ public: void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWidget *widget = 0) override; void modelDataChanged(const QModelIndex &topLeft = QModelIndex(), const QModelIndex &bottomRight = QModelIndex()) override; void settingsToggled(bool toggled); - void settingsChanged() override; void plot_depth_sample(struct plot_data *entry, QFlags flags, const QColor &color); int maxCeiling(int row); @@ -195,7 +193,6 @@ public: DiveCalculatedTissue(const DivePlotDataModel &model, const DiveCartesianAxis &hAxis, int hColumn, const DiveCartesianAxis &vAxis, int vColumn, ProfileWidget2 *profileWidget); void setVisible(bool visible); - void settingsChanged() override; }; class PartialPressureGasItem : public AbstractProfilePolygonItem { -- cgit v1.2.3-70-g09d2