From 43c3885249fb867e7c33c8b3b5846d44e908774f Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Mon, 23 Jul 2018 23:41:23 +0200 Subject: Undo: isolate undo-commands This refactors the undo-commands (which are now only "commands"). - Move everything in namespace Command. This allows shortening of names without polluting the global namespace. Moreover, the prefix Command:: will immediately signal that the undo-machinery is invoked. This is more terse than UndoCommands::instance()->... - Remove the Undo in front of the class-names. Creating an "UndoX" object to do "X" is paradoxical. - Create a base class for all commands that defines the Qt-translation functions. Thus all translations end up in the "Command" context. - Add a workToBeDone() function, which signals whether this should be added to the UndoStack. Thus the caller doesn't have to check itself whether this any work will be done. Note: Qt5.9 introduces "setObsolete" which does the same. - Split into public and internal header files. In the public header file only export the function calls, thus hiding all implementation details from the caller. - Split in different translation units: One for the stubs, one for the base classes and one for groups of commands. Currently, there is only one class of commands: divelist-commands. - Move the undoStack from the MainWindow class into commands_base.cpp. If we want to implement MDI, this can easily be moved into an appropriate Document class. Signed-off-by: Berthold Stoeger --- profile-widget/profilewidget2.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'profile-widget/profilewidget2.cpp') diff --git a/profile-widget/profilewidget2.cpp b/profile-widget/profilewidget2.cpp index 79b70d719..9221ff293 100644 --- a/profile-widget/profilewidget2.cpp +++ b/profile-widget/profilewidget2.cpp @@ -23,7 +23,7 @@ #include "desktop-widgets/diveplanner.h" #include "desktop-widgets/simplewidgets.h" #include "desktop-widgets/divepicturewidget.h" -#include "desktop-widgets/undocommands.h" +#include "desktop-widgets/command.h" #include "desktop-widgets/mainwindow.h" #include "core/qthelper.h" #include "core/gettextfromc.h" @@ -1685,8 +1685,7 @@ void ProfileWidget2::splitDive() QPointF scenePos = mapToScene(mapFromGlobal(action->data().toPoint())); duration_t time; time.seconds = lrint(timeAxis->valueAt(scenePos)); - UndoSplitDives *undoCommand = new UndoSplitDives(d, time); - MainWindow::instance()->undoStack->push(undoCommand); + Command::splitDives(d, time); emit updateDiveInfo(false); #endif } -- cgit v1.2.3-70-g09d2