From 47d673bda324bf4a884fa41a0b95d08692a6f712 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Wed, 23 Dec 2020 12:26:12 +0100 Subject: profile: remove TankItem's connection to the resize signal Since the initial commit introducing TankItem, there was a connection that replotted the item if the horizontal axis sent the sizeChanged() signal. I never managed to create this signal for the horizontal axis, only for the vertical axes. Therefore remove this thing. If it turns out that we need it after all, readd it in a more deterministic way (i.e. call where it is needed). Signed-off-by: Berthold Stoeger --- profile-widget/tankitem.cpp | 5 +---- profile-widget/tankitem.h | 10 +++------- 2 files changed, 4 insertions(+), 11 deletions(-) (limited to 'profile-widget') diff --git a/profile-widget/tankitem.cpp b/profile-widget/tankitem.cpp index 5469ffc0d..d87b1228b 100644 --- a/profile-widget/tankitem.cpp +++ b/profile-widget/tankitem.cpp @@ -7,8 +7,7 @@ static const qreal height = 3.0; -TankItem::TankItem(QObject *parent) : - QObject(parent), +TankItem::TankItem() : plotEndTime(-1) { QColor red(PERSIANRED1); @@ -111,6 +110,4 @@ void TankItem::replot() void TankItem::setHorizontalAxis(DiveCartesianAxis *horizontal) { hAxis = horizontal; - connect(hAxis, SIGNAL(sizeChanged()), this, SLOT(replot())); - replot(); } diff --git a/profile-widget/tankitem.h b/profile-widget/tankitem.h index b89b6b0ff..f3e0c0238 100644 --- a/profile-widget/tankitem.h +++ b/profile-widget/tankitem.h @@ -8,20 +8,16 @@ #include "profile-widget/divecartesianaxis.h" #include "core/dive.h" -class TankItem : public QObject, public QGraphicsRectItem +class TankItem : public QGraphicsRectItem { - Q_OBJECT - public: - explicit TankItem(QObject *parent = 0); + explicit TankItem(); void setHorizontalAxis(DiveCartesianAxis *horizontal); void setData(struct plot_info *plotInfo, struct dive *d); -public slots: - void replot(); - private: void createBar(int startTime, int stopTime, struct gasmix gas); + void replot(); DiveCartesianAxis *hAxis; int plotEndTime; QBrush air, nitrox, oxygen, trimix; -- cgit v1.2.3-70-g09d2