From 2d760a7bff71c46c5aeba37c40d236ea16eefea2 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Sun, 3 Apr 2016 17:31:59 -0500 Subject: Don't write back dive data that hasn't changed in git This caches the git ID for the dive on load, and avoids building the dive directory and hashing it on save as long as nothing has invalidated the git ID cache. That should make it much faster to write back data to the git repository, since the dive tree structure and the divecomputer blobs in particular are the bulk of it (due to all the sample data). It's not actually the git operations that are all that expensive, it's literally generating the big blob with all the snprintf() calls for the data. The git save used to be a fairly expensive with large data sets, especially noticeable on mobile with much weaker CPU's. This should speed things up by at least a factor of two. Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel --- qt-mobile/qmlmanager.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'qt-mobile') diff --git a/qt-mobile/qmlmanager.cpp b/qt-mobile/qmlmanager.cpp index 048e787cf..c6e6c5025 100644 --- a/qt-mobile/qmlmanager.cpp +++ b/qt-mobile/qmlmanager.cpp @@ -447,6 +447,7 @@ void QMLManager::commitChanges(QString diveId, QString date, QString location, Q bool diveChanged = false; bool needResort = false; + invalidate_dive_cache(d); if (date != get_dive_date_string(d->when)) { diveChanged = needResort = true; QDateTime newDate; -- cgit v1.2.3-70-g09d2