From 8b93d67106acaa4f146ee683b837d0b0cf4e31b6 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Mon, 13 Apr 2020 10:42:42 +0200 Subject: mobile: remove fine-grained notification When initializing the fulltext-cache and the dive-list, every 100 dives a notification was shown. I had a feeling that this made startup significantly slower, but that could have been purely psychological. Therefore I measured and indeed, removing the fine-grained notification, it becomes *significantly* faster. For a 3500 dives test log with mobile-on-desktop: Initialization of the fulltext: 1350 ms -> 730 ms (-46%) Initialization of the divelistmodel: 689 ms -> 113 ms (-83%) Let's remove the fine-grained notification. There *is* a visual indication of work-in-progress anyway. Signed-off-by: Berthold Stoeger --- qt-models/divetripmodel.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'qt-models') diff --git a/qt-models/divetripmodel.cpp b/qt-models/divetripmodel.cpp index 0f381410a..174e5af54 100644 --- a/qt-models/divetripmodel.cpp +++ b/qt-models/divetripmodel.cpp @@ -725,8 +725,6 @@ void DiveTripModelTree::populate() uiNotification(QObject::tr("populate data model")); uiNotification(QObject::tr("start processing")); for (int i = 0; i < dive_table.nr; ++i) { - if (i % 100 == 99) - uiNotification(QObject::tr("\r%1 dives processed").arg(i + 1)); dive *d = get_dive(i); update_cylinder_related_info(d); if (d->hidden_by_filter) @@ -754,7 +752,7 @@ void DiveTripModelTree::populate() // Remember the index of the current dive oldCurrent = current_dive; - uiNotification(QObject::tr("\r%1 dives processed").arg(dive_table.nr)); + uiNotification(QObject::tr("%1 dives processed").arg(dive_table.nr)); } int DiveTripModelTree::rowCount(const QModelIndex &parent) const -- cgit v1.2.3-70-g09d2