From e434b5aa4066990a1dbf67670e09b650d87be753 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Mon, 11 Nov 2019 21:36:51 +0100 Subject: Cleanup: introduce DiveTripModelBase::IS_TRIP_ROLE To test whether an entry is a trip, we passed a pointer to the trip through a QVariant and tested that for null-ity. Passing pointers through QVariants has given us myriads of problems in QML, therefore introduce a bool IS_TRIP_ROLE Signed-off-by: Berthold Stoeger --- qt-models/divetripmodel.cpp | 2 ++ qt-models/divetripmodel.h | 1 + qt-models/filtermodels.cpp | 3 +-- 3 files changed, 4 insertions(+), 2 deletions(-) (limited to 'qt-models') diff --git a/qt-models/divetripmodel.cpp b/qt-models/divetripmodel.cpp index ada648762..4e8478a33 100644 --- a/qt-models/divetripmodel.cpp +++ b/qt-models/divetripmodel.cpp @@ -723,6 +723,8 @@ QVariant DiveTripModelTree::data(const QModelIndex &index, int role) const return defaultModelFont(); dive_or_trip entry = tripOrDive(index); + if (role == IS_TRIP_ROLE) + return !!entry.trip; if (entry.trip) return tripData(entry.trip, index.column(), role); else if (entry.dive) diff --git a/qt-models/divetripmodel.h b/qt-models/divetripmodel.h index e0eefb1f0..dc0d4b299 100644 --- a/qt-models/divetripmodel.h +++ b/qt-models/divetripmodel.h @@ -49,6 +49,7 @@ public: enum ExtraRoles { STAR_ROLE = Qt::UserRole + 1, + IS_TRIP_ROLE, DIVE_ROLE, TRIP_ROLE, DIVE_IDX, diff --git a/qt-models/filtermodels.cpp b/qt-models/filtermodels.cpp index 0226e1220..27bb33856 100644 --- a/qt-models/filtermodels.cpp +++ b/qt-models/filtermodels.cpp @@ -228,8 +228,7 @@ void MultiFilterSortModel::myInvalidate() for (int i = 0; i < m->rowCount(QModelIndex()); ++i) { QModelIndex idx = m->index(i, 0, QModelIndex()); - dive_trip *trip = m->data(idx, DiveTripModelBase::TRIP_ROLE).value(); - if (trip) { + if (m->data(idx, DiveTripModelBase::IS_TRIP_ROLE).toBool()) { // This is a trip -> loop over all dives and see if any is selected bool showTrip = false; -- cgit v1.2.3-70-g09d2