From 1c72b8b0545e6a13ea3db917a1434152c73a3c3b Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Wed, 8 Jan 2014 14:51:22 +0800 Subject: const'ify our strtod() helper functions The C library doesn't use const char pointers for legacy reasons (and because you *can* modify the string the end pointer points to), but let's do it in our internal implementation just because it's a nice guarantee to have. We actually used to have a non-const end pointer and replace a decimal comma with a decimal dot, but that was because we didn't have the fancy "allow commas" flags. So by using our own strtod_flags() function, we can now keep all the strings we parse read-only rather than modify them as we parse them. Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel --- qt-ui/models.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'qt-ui') diff --git a/qt-ui/models.cpp b/qt-ui/models.cpp index cb956702b..35696a778 100644 --- a/qt-ui/models.cpp +++ b/qt-ui/models.cpp @@ -464,9 +464,9 @@ void WeightModel::passInData(const QModelIndex& index, const QVariant& value) } } -weight_t string_to_weight(char *str) +weight_t string_to_weight(const char *str) { - char *end; + const char *end; double value = strtod_flags(str, &end, 0); QString rest = QString(end).trimmed(); QString local_kg = WeightModel::tr("kg"); -- cgit v1.2.3-70-g09d2