From 6925d13aa499b246c405687436b70d691eabe6fa Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Tue, 24 Dec 2013 09:38:35 -0200 Subject: Rework foreach for a faster iteration. The old code used a QString instead of a const QString&, wich mean that each foreach step the string was copied. added a break on the if-found-true to stop the foreach, since we already found it. Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel --- qt-ui/globe.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'qt-ui') diff --git a/qt-ui/globe.cpp b/qt-ui/globe.cpp index e0f94bbd5..cab24ba4a 100644 --- a/qt-ui/globe.cpp +++ b/qt-ui/globe.cpp @@ -30,12 +30,15 @@ GlobeGPS::GlobeGPS(QWidget* parent) : MarbleWidget(parent), loadedDives(0), edit // if not, check if they are in a known location MapThemeManager mtm; QStringList list = mtm.mapThemeIds(); - QString theme, subsurfaceDataPath; + QString subsurfaceDataPath; QDir marble; bool foundGoogleMap = false; - Q_FOREACH(theme, list) - if (theme == "earth/googlesat/googlesat.dgml") + Q_FOREACH(const QString& theme, list){ + if (theme == "earth/googlesat/googlesat.dgml"){ foundGoogleMap = true; + break; + } + } if (!foundGoogleMap) { subsurfaceDataPath = getSubsurfaceDataPath("marbledata"); if (subsurfaceDataPath != "") { -- cgit v1.2.3-70-g09d2