From a92484e4edd7ad2609d9d9e09cdb064e370e745d Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Fri, 9 Jan 2015 12:38:39 -0800 Subject: Dive d/l selection UI: remove setData() method Since we now track all clicks on the row, having the setData() actually neutralized the action that we took on the clicked() signal. Now you can select / deselect a dive, regardless where in the row you click. Signed-off-by: Dirk Hohndel --- qt-ui/downloadfromdivecomputer.cpp | 16 ---------------- qt-ui/downloadfromdivecomputer.h | 1 - 2 files changed, 17 deletions(-) (limited to 'qt-ui') diff --git a/qt-ui/downloadfromdivecomputer.cpp b/qt-ui/downloadfromdivecomputer.cpp index 5ac39ebf3..fb981c9f8 100644 --- a/qt-ui/downloadfromdivecomputer.cpp +++ b/qt-ui/downloadfromdivecomputer.cpp @@ -586,22 +586,6 @@ QVariant DiveImportedModel::data(const QModelIndex &index, int role) const return QVariant(); } -bool DiveImportedModel::setData(const QModelIndex &index, const QVariant &value, int role) -{ - if (!index.isValid()) - return false; - - if (index.row() + firstIndex > lastIndex) - return false; - - if (role != Qt::CheckStateRole) - return false; - - checkStates[index.row()] = value.toBool(); - dataChanged(index, index, QVector() << Qt::CheckStateRole); - return true; -} - void DiveImportedModel::changeSelected(QModelIndex clickedIndex) { checkStates[clickedIndex.row()] = !checkStates[clickedIndex.row()]; diff --git a/qt-ui/downloadfromdivecomputer.h b/qt-ui/downloadfromdivecomputer.h index efec64f80..70b3c8e62 100644 --- a/qt-ui/downloadfromdivecomputer.h +++ b/qt-ui/downloadfromdivecomputer.h @@ -34,7 +34,6 @@ public: int rowCount(const QModelIndex& index = QModelIndex()) const; QVariant data(const QModelIndex& index, int role) const; QVariant headerData(int section, Qt::Orientation orientation, int role) const; - bool setData(const QModelIndex &index, const QVariant &value, int role); void setImportedDivesIndexes(int first, int last); Qt::ItemFlags flags(const QModelIndex &index) const; void removeUnused(); -- cgit v1.2.3-70-g09d2