From 2b06e4be671930bc22feb830f328871a31315d9f Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Mon, 12 May 2014 13:19:57 -0300 Subject: Move printGpsCoords from MainTab to QtHelper Last time I touched this I got a scream from dirk, but then I looked at the code again and the problem that I faced was that I broke translations in a sad way, well, now I broke it again. However, this method shouldn't belong to MainTab ( because of that thingy that I said before and also many others: Separate the logic of your application from the UI specific code ) This generates a string that's going to be used on the Interface, it doesn't display it on the interface. Move it down below makes it easier to test ( I don't need to create an Widget and worry about the parent-relationship with the mainwindow just to test this function, for instance. ) Signed-off-by: Tomaz Canabrava Signed-off-by: Dirk Hohndel --- qthelper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'qthelper.h') diff --git a/qthelper.h b/qthelper.h index 9d31f5a12..6067e1359 100644 --- a/qthelper.h +++ b/qthelper.h @@ -41,6 +41,6 @@ public: QString weight_string(int weight_in_grams); bool gpsHasChanged(struct dive *dive, struct dive *master, const QString &gps_text, bool *parsed); - +QString printGPSCoords(int lat, int lon); QList getDivesInTrip(dive_trip_t *trip); #endif // QTHELPER_H -- cgit v1.2.3-70-g09d2