From 643a964d099b2bac29500dcd70aaec3ee3e9b0bd Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Mon, 25 Mar 2019 20:52:00 +0100 Subject: Cleanup: unconstify string argument to add_to_string() add_to_string() frees the original string that is passed in. This should therefore not be of "const char *" type, as the contents of the string *will* be modified (or more precisely: destroyed). Same for the congener smtk_concat_str(). Signed-off-by: Berthold Stoeger --- smtk-import/smartrak.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'smtk-import/smartrak.c') diff --git a/smtk-import/smartrak.c b/smtk-import/smartrak.c index 63b3af799..8ef01de48 100644 --- a/smtk-import/smartrak.c +++ b/smtk-import/smartrak.c @@ -211,7 +211,7 @@ static MdbTableDef *smtk_open_table(MdbHandle *mdb, char *tablename, MdbColumn * This is based in add_to_string() and add_to_string_va(), and, as its parents * frees the original string. */ -static char *smtk_concat_str(const char *orig, const char *sep, const char *fmt, ...) +static char *smtk_concat_str(char *orig, const char *sep, const char *fmt, ...) { char *str; va_list args; @@ -229,7 +229,7 @@ static char *smtk_concat_str(const char *orig, const char *sep, const char *fmt, free_buffer(&out); free_buffer(&in); - free((void *)orig); + free(orig); return str; } -- cgit v1.2.3-70-g09d2