From 7446e8cddddcf02b704bdc1a8bfe74609acbb0d9 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Fri, 5 Mar 2021 09:35:13 +0100 Subject: statistics: don't divide by totalCount = 0 in pie charts This silences a Coverity warning. In principle, this should never happen, since there are no slices if totalCount is 0. Signed-off-by: Berthold Stoeger --- stats/pieseries.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'stats') diff --git a/stats/pieseries.cpp b/stats/pieseries.cpp index c425fffd2..84f80b01d 100644 --- a/stats/pieseries.cpp +++ b/stats/pieseries.cpp @@ -27,6 +27,11 @@ PieSeries::Item::Item(StatsView &view, const QString &name, int from, std::vecto QLocale loc; int count = (int)dives.size(); + + // totalCount = 0 shouldn't happen, but for robustness' sake, let's not divide by zero. + if (totalCount <= 0) + totalCount = count = 1; + angleFrom = static_cast(from) / totalCount; angleTo = static_cast(from + count) / totalCount; double meanAngle = M_PI / 2.0 - (from + count / 2.0) / totalCount * M_PI * 2.0; // Note: "-" because we go CW. -- cgit v1.2.3-70-g09d2