From 1cb5419a57da4c2c278e6ce364e9c10daaac2633 Mon Sep 17 00:00:00 2001
From: Dirk Hohndel <dirk@hohndel.org>
Date: Thu, 3 Dec 2015 23:14:20 -0800
Subject: Cloud storage: do not store the actual pictures in git
Adding pictures to the repository was a big mistake on my part. It's very
easy for the git repositories to reach a gigabyte and more making sync
times (and especially "first download" times) completely unreasonable.
This doesn't solve the problem for existing repositories (as the pictures
are already there, in the git history), but at least it prevents us from
storing more pictures out there.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
---
subsurface-core/save-git.c | 3 +++
1 file changed, 3 insertions(+)
(limited to 'subsurface-core')
diff --git a/subsurface-core/save-git.c b/subsurface-core/save-git.c
index d3601a272..e4bf1a5cd 100644
--- a/subsurface-core/save-git.c
+++ b/subsurface-core/save-git.c
@@ -634,6 +634,8 @@ static int save_one_picture(git_repository *repo, struct dir *dir, struct pictur
offset -= h *3600;
error = blob_insert(repo, dir, &buf, "%c%02u=%02u=%02u",
sign, h, FRACTION(offset, 60));
+#if 0
+ /* storing pictures into git was a mistake. This makes for HUGE git repositories */
if (!error) {
/* next store the actual picture; we prefix all picture names
* with "PIC-" to make things easier on the parsing side */
@@ -643,6 +645,7 @@ static int save_one_picture(git_repository *repo, struct dir *dir, struct pictur
error = blob_insert_fromdisk(repo, dir, localfn, mb_cstring(&namebuf));
free((void *)localfn);
}
+#endif
return error;
}
--
cgit v1.2.3-70-g09d2