From 788d65a527b8daf511ca70c33b14bf88cf1a37b0 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Wed, 23 Mar 2016 17:19:05 -0700 Subject: Make code easier to read (and avoid warning) The old expression wass correct because if dive_table.dives[j]->number is != 0, then !dive_table.dives[j]->number is 0 and vice versa. But come on... The new code seems much more natural and easier to read. And of course the Apple compilers by default gave a warning because they suspected a precedence bug with the old code. Signed-off-by: Dirk Hohndel --- subsurface-core/divelist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'subsurface-core') diff --git a/subsurface-core/divelist.c b/subsurface-core/divelist.c index bac63ed97..99e09eab6 100644 --- a/subsurface-core/divelist.c +++ b/subsurface-core/divelist.c @@ -866,7 +866,7 @@ struct dive *merge_two_dives(struct dive *a, struct dive *b) // renumber dives from merged one in advance by difference between // merged dives numbers. Do not renumber if actual number is zero. for (; j < dive_table.nr; j++) - if (!dive_table.dives[j]->number == 0) + if (dive_table.dives[j]->number != 0) dive_table.dives[j]->number -= factor; mark_divelist_changed(true); -- cgit v1.2.3-70-g09d2