From 59526e948aea42b977a3976293fbfdfe561dec97 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Wed, 3 Jan 2018 18:03:28 +0100 Subject: Remove cloud_background_sync preferences option The preferences flag cloud_background_sync used to be used heavily in the mobile code, but is not used there anymore. Now, it is accessed only in one place, but does not do what it actually says: If it is off, the remote storage is not synced on save (but will be synced on next load). Syncing on save can also be prevented by unchecking the "Cloud online" menu checkbox. Since the latter seems more logical and general (support for non-cloud remote git repositories), remove the cloud_background_sync option. Signed-off-by: Berthold Stoeger --- tests/testgitstorage.cpp | 1 - tests/testpreferences.cpp | 4 ---- 2 files changed, 5 deletions(-) (limited to 'tests') diff --git a/tests/testgitstorage.cpp b/tests/testgitstorage.cpp index 9387fbd81..2edc8e305 100644 --- a/tests/testgitstorage.cpp +++ b/tests/testgitstorage.cpp @@ -43,7 +43,6 @@ void TestGitStorage::initTestCase() s.endGroup(); prefs.cloud_storage_email_encoded = strdup("ssrftest@hohndel.org"); prefs.cloud_storage_password = strdup("geheim"); - prefs.cloud_background_sync = true; QNetworkProxy proxy; proxy.setType(QNetworkProxy::ProxyType(prefs.proxy_type)); proxy.setHostName(prefs.proxy_host); diff --git a/tests/testpreferences.cpp b/tests/testpreferences.cpp index bc6e90213..585044fd0 100644 --- a/tests/testpreferences.cpp +++ b/tests/testpreferences.cpp @@ -25,10 +25,6 @@ void TestPreferences::testPreferences() pref->load(); auto cloud = pref->cloud_storage; - cloud->setBackgroundSync(true); - TEST(cloud->backgroundSync(), true); - cloud->setBackgroundSync(false); - TEST(cloud->backgroundSync(), false); cloud->setBaseUrl("test_one"); TEST(cloud->baseUrl(), QStringLiteral("test_one")); -- cgit v1.2.3-70-g09d2