aboutsummaryrefslogtreecommitdiffstats
path: root/keyboards/maxr1998
diff options
context:
space:
mode:
authorGravatar Max Rumpf <max.rumpf1998@gmail.com>2020-01-28 18:08:39 +0100
committerGravatar James Young <18669334+noroadsleft@users.noreply.github.com>2020-01-28 09:08:39 -0800
commit0d80c7bd598c1296d31554fe8c82843415696a18 (patch)
treee28cefaac4b2cde21e60724e2ca48960568f9689 /keyboards/maxr1998
parent4d06d2835c87f3eed694493fb749527032a78ec2 (diff)
downloadqmk_firmware-0d80c7bd598c1296d31554fe8c82843415696a18.tar.gz
[Keyboard] Fix Pulse4k info.json LAYOUT name (#7965)
* Fix Pulse4k info.json LAYOUT name * Add missing functions to fix configurator Add empty encoder functions to the keyboard code, as the configurator doesn't see the keymap defined functions at first. To be able to override these functions, they are marked as 'weak'. * Rework encoder functions another time Default implementation is now provided as part of the keyboard, but they can still be overriden within the keymap (template is commented out by default)
Diffstat (limited to 'keyboards/maxr1998')
-rw-r--r--keyboards/maxr1998/pulse4k/info.json2
-rw-r--r--keyboards/maxr1998/pulse4k/keymaps/default/keymap.c13
-rw-r--r--keyboards/maxr1998/pulse4k/pulse4k.c16
3 files changed, 20 insertions, 11 deletions
diff --git a/keyboards/maxr1998/pulse4k/info.json b/keyboards/maxr1998/pulse4k/info.json
index 0ac4f063c..a653f8e09 100644
--- a/keyboards/maxr1998/pulse4k/info.json
+++ b/keyboards/maxr1998/pulse4k/info.json
@@ -6,7 +6,7 @@
"width": 3,
"height": 2,
"layouts": {
- "LAYOUT_pulse4k": {
+ "LAYOUT": {
"key_count": 6,
"layout": [
{ "w": 1, "x": 0, "y": 0 },
diff --git a/keyboards/maxr1998/pulse4k/keymaps/default/keymap.c b/keyboards/maxr1998/pulse4k/keymaps/default/keymap.c
index 873c87d1f..67331235b 100644
--- a/keyboards/maxr1998/pulse4k/keymaps/default/keymap.c
+++ b/keyboards/maxr1998/pulse4k/keymaps/default/keymap.c
@@ -31,18 +31,11 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
void matrix_init_user(void) {
}
+// Override if necessary
+/*
void encoder_one_update(bool clockwise) {
- if (clockwise) {
- tap_code(KC_PGDN);
- } else {
- tap_code(KC_PGUP);
- }
}
void encoder_two_update(bool clockwise) {
- if (clockwise) {
- tap_code(KC_VOLU);
- } else {
- tap_code(KC_VOLD);
- }
}
+//*/
diff --git a/keyboards/maxr1998/pulse4k/pulse4k.c b/keyboards/maxr1998/pulse4k/pulse4k.c
index ee3d41ccd..2ec9dca73 100644
--- a/keyboards/maxr1998/pulse4k/pulse4k.c
+++ b/keyboards/maxr1998/pulse4k/pulse4k.c
@@ -59,3 +59,19 @@ void encoder_update_kb(uint8_t index, bool clockwise) {
} else encoder_two_update(clockwise);
}
}
+
+__attribute__((weak)) void encoder_one_update(bool clockwise) {
+ if (clockwise) {
+ tap_code(KC_PGDN);
+ } else {
+ tap_code(KC_PGUP);
+ }
+}
+
+__attribute__((weak)) void encoder_two_update(bool clockwise) {
+ if (clockwise) {
+ tap_code(KC_VOLU);
+ } else {
+ tap_code(KC_VOLD);
+ }
+}