Migrate fn_actions for default keymaps (#4935)

* Migrate fn_actions for default keymaps

* Rename the Grave/Escape Shift masks

* No need for shift_esc_shift_mask

* Change breaks to return false

* Right align pointers

* Add default case

* Separate cases with empty lines

1 files changed, 2 insertions, 73 deletions

diff --git a/keyboards/satan/keymaps/iso_split_rshift/keymap.c b/keyboards/satan/keymaps/iso_split_rshift/keymap.c
index d73a01aea..156515673 100644
--- a/keyboards/satan/keymaps/iso_split_rshift/keymap.c
+++ b/keyboards/satan/keymaps/iso_split_rshift/keymap.c
@@ -113,36 +113,11 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
     [_SFX] = LAYOUT_60_iso_split_rshift(
         RESET,   _______, _______, _______, _______, _______, _______, KC_7,    KC_8,    KC_9, _______, _______, _______, KC_BSPC, \
         _______, _______, _______, _______, _______, _______, _______, KC_4,    KC_5,    KC_6, _______, _______, _______, \
-        _______, F(2),    F(3),    _______, _______, _______, _______, KC_1,    KC_2,    KC_3, _______, _______, XXXXXXX, KC_ENT,  \
-        _______, F(4),    F(5),    F(6),    F(7),    F(8),    F(9),    _______, _______, KC_0, _______, KC_SLSH, KC_UP,   _______, \
+        _______, RGB_TOG, RGB_MOD, _______, _______, _______, _______, KC_1,    KC_2,    KC_3, _______, _______, XXXXXXX, KC_ENT,  \
+        _______, RGB_HUI, RGB_HUD, RGB_SAI, RGB_SAD, RGB_VAI, RGB_VAD, _______, _______, KC_0, _______, KC_SLSH, KC_UP,   _______, \
         _______, _______, _______,                            _______,                         _______, KC_LEFT, KC_DOWN, KC_RGHT),
 };
 
-enum function_id {
-    LAUNCH,
-    RGBLED_TOGGLE,
-    RGBLED_STEP_MODE,
-    RGBLED_INCREASE_HUE,
-    RGBLED_DECREASE_HUE,
-    RGBLED_INCREASE_SAT,
-    RGBLED_DECREASE_SAT,
-    RGBLED_INCREASE_VAL,
-    RGBLED_DECREASE_VAL,
-};
-
-const uint16_t PROGMEM fn_actions[] = {
-    [1]  = ACTION_FUNCTION(LAUNCH),
-    [2]  = ACTION_FUNCTION(RGBLED_TOGGLE),
-    [3]  = ACTION_FUNCTION(RGBLED_STEP_MODE),
-    [4]  = ACTION_FUNCTION(RGBLED_INCREASE_HUE),
-    [5]  = ACTION_FUNCTION(RGBLED_DECREASE_HUE),
-    [6]  = ACTION_FUNCTION(RGBLED_INCREASE_SAT),
-    [7]  = ACTION_FUNCTION(RGBLED_DECREASE_SAT),
-    [8]  = ACTION_FUNCTION(RGBLED_INCREASE_VAL),
-    [9]  = ACTION_FUNCTION(RGBLED_DECREASE_VAL),
-    [10] = ACTION_MODS_TAP_KEY(MOD_LCTL, KC_ENT),
-};
-
 const macro_t *action_get_macro(keyrecord_t *record, uint8_t id, uint8_t opt)
 {
     // MACRODOWN only works in this function
@@ -160,49 +135,3 @@ const macro_t *action_get_macro(keyrecord_t *record, uint8_t id, uint8_t opt)
     }
     return MACRO_NONE;
 };
-
-void action_function(keyrecord_t *record, uint8_t id, uint8_t opt) {
-    switch (id) {
-        case RGBLED_TOGGLE:
-            //led operations
-            if (record->event.pressed) {
-                rgblight_toggle();
-            }
-            break;
-        case RGBLED_INCREASE_HUE:
-            if (record->event.pressed) {
-                rgblight_increase_hue();
-            }
-            break;
-        case RGBLED_DECREASE_HUE:
-            if (record->event.pressed) {
-                rgblight_decrease_hue();
-            }
-            break;
-        case RGBLED_INCREASE_SAT:
-            if (record->event.pressed) {
-                rgblight_increase_sat();
-            }
-            break;
-        case RGBLED_DECREASE_SAT:
-            if (record->event.pressed) {
-                rgblight_decrease_sat();
-            }
-            break;
-        case RGBLED_INCREASE_VAL:
-            if (record->event.pressed) {
-                rgblight_increase_val();
-            }
-            break;
-        case RGBLED_DECREASE_VAL:
-            if (record->event.pressed) {
-                rgblight_decrease_val();
-            }
-            break;
-        case RGBLED_STEP_MODE:
-            if (record->event.pressed) {
-                rgblight_step();
-            }
-            break;
-    }
-}