diff options
| author |  fredizzimo <fsundvik@gmail.com> | 2020-03-13 20:09:38 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2020-03-13 14:09:38 -0400 |
| commit | 9e8767917d628afd3dc43759d1d50151c61944a1 (patch) | |
| tree | 0060b8968d5e9df38c37b375e4eb2d6a0d65ac0c /tmk_core/common/action.c | |
| parent | f89439ae09c06d0e85f59af2bc5e020d141f23d6 (diff) | |
| download | qmk_firmware-9e8767917d628afd3dc43759d1d50151c61944a1.tar.gz | |
Fix pressing two keys with the same keycode but different modifiers (#2710)
* Fix extra keyboard report during test_fixture teardown
* Add tests for pressing two keys with only different modifers
* Fix #1708
When two keys that use the same keycode, but different modifiers were
pressed at the same time, the second keypress wasn't registered. This is
fixed by forcing a key release when we detect a new press for the same
keycode.
* Fix the NKRO version of is_key_pressed
* Fix uninitalized loop variable
Co-authored-by: Jack Humbert <jack.humb@gmail.com>
Diffstat (limited to 'tmk_core/common/action.c')
| -rw-r--r-- | tmk_core/common/action.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/tmk_core/common/action.c b/tmk_core/common/action.c index 0ec4a43ee..2deafd465 100644 --- a/tmk_core/common/action.c +++ b/tmk_core/common/action.c @@ -754,6 +754,13 @@ void register_code(uint8_t code) { */ #endif { + // Force a new key press if the key is already pressed + // without this, keys with the same keycode, but different + // modifiers will be reported incorrectly, see issue #1708 + if (is_key_pressed(keyboard_report, code)) { + del_key(code); + send_keyboard_report(); + } add_key(code); send_keyboard_report(); } |