aboutsummaryrefslogtreecommitdiffstats
path: root/.gitmodules
diff options
context:
space:
mode:
authorGravatar Linus Torvalds <torvalds@linux-foundation.org>2018-10-06 10:50:25 -0700
committerGravatar Dirk Hohndel <dirk@hohndel.org>2018-10-06 19:38:28 -0700
commitec532b8f5963221ff5aad37799ace869dacb76a5 (patch)
treeffe64cf0aadb25d6ce0c47bf77b189865fe52a6b /.gitmodules
parentebee0c4c24e3b2a327c6b7275093690d2bff66bb (diff)
downloadsubsurface-ec532b8f5963221ff5aad37799ace869dacb76a5.tar.gz
qt-ble: move basic uuid filtering back to service discovery
In commit 30fb7bf35c9e ("qt-ble: set up infrastructure for better preferred service choice") I moved the service filtering from the addService() callback into the "select_preferred_service()" function that picks the right service for the device. That was nice for debugging, since it meant that we showed the details of _all_ services, but it also meant that we ended up starting service discovery on _all_ services, whether they looked at all interesting or not. And that can make the BLE device discovery process quite a bit slower. The debugging advantage is real, but honestly, service discovery can generally be better done with specialized tools like the Nordic nRF app, so the debugging advantage of just listing all the details of all the services is not really worth the discovery slowdown in general. So move the basic "filter by uuid" back to the service discovery phase, and don't bother starting service detail discovery for the services that we can dismiss immediately just based on the service UUID. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '.gitmodules')
0 files changed, 0 insertions, 0 deletions