summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Linus Torvalds <torvalds@linux-foundation.org>2012-11-10 20:02:21 +0100
committerGravatar Dirk Hohndel <dirk@hohndel.org>2012-11-11 05:19:10 +0100
commit776f92edcf9e1fb563f8cae5bc49c54a85ff2faf (patch)
treeb175d1ec8be96ef19c894c4ee70b10f43b2fcb9f
parent38c79d149db09cbb856e4827ce7a24d742c91917 (diff)
downloadsubsurface-776f92edcf9e1fb563f8cae5bc49c54a85ff2faf.tar.gz
Don't simplify 'bookmark' and 'heading' events
Add the bookmark and heading events to the list of events not to be simplified just because they are redundant - in both cases they are about the user doing something explicit (like the gaschange), so even if the data is otherwise identical, they should likely be saved. That said, both events are kind of pointless (we don't actually seem to save the heading value for the heading events, and bookmarks are universally just due to user error in at least my case). But still.. This overly aggressive filtering was introduced in commit 6ad73a8f043b ("Improve logic handling events"). Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
-rw-r--r--dive.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/dive.c b/dive.c
index 4b894cb48..65cfc4d53 100644
--- a/dive.c
+++ b/dive.c
@@ -378,6 +378,10 @@ static gboolean is_potentially_redundant(struct event *event)
{
if (!strcmp(event->name, "gaschange"))
return FALSE;
+ if (!strcmp(event->name, "bookmark"))
+ return FALSE;
+ if (!strcmp(event->name, "heading"))
+ return FALSE;
return TRUE;
}