summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Dirk Hohndel <dirk@hohndel.org>2015-10-01 07:52:13 -0400
committerGravatar Dirk Hohndel <dirk@hohndel.org>2015-10-01 07:52:13 -0400
commitefa4dc3c9a8a65935d05d3928675ab01a3aebb01 (patch)
tree30f1fcec2afd37b3525a9e118a0b0e08fa67ac3a
parenta52f8f8168746e3b7685c6622b13eee5cba8593d (diff)
downloadsubsurface-efa4dc3c9a8a65935d05d3928675ab01a3aebb01.tar.gz
Don't zoom out the globe if the dive site has no GPS
This may or may not look intuitive, but it can cause problems with the zoom seemingly stuck all out (because of the timeouts). So instead stay where you are. If the current dive site has GPS then its flag will be bigger and brighter - so there still is visual feedback. But there's less crazy zooming around. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
-rw-r--r--qt-ui/globe.cpp8
1 files changed, 5 insertions, 3 deletions
diff --git a/qt-ui/globe.cpp b/qt-ui/globe.cpp
index a0866e475..135f195a1 100644
--- a/qt-ui/globe.cpp
+++ b/qt-ui/globe.cpp
@@ -251,7 +251,8 @@ void GlobeGPS::reload()
void GlobeGPS::centerOnDiveSite(struct dive_site *ds)
{
if (!dive_site_has_gps_location(ds)) {
- zoomOutForNoGPS();
+ // this is not intuitive and at times causes trouble - let's comment it out for now
+ // zoomOutForNoGPS();
return;
}
qreal longitude = ds->longitude.udeg / 1000000.0;
@@ -328,8 +329,9 @@ void GlobeGPS::prepareForGetDiveCoordinates()
messageWidget->setCloseButtonVisible(false);
messageWidget->animatedShow();
editingDiveLocation = true;
- if (!dive_has_gps_location(current_dive))
- zoomOutForNoGPS();
+ // this is not intuitive and at times causes trouble - let's comment it out for now
+ // if (!dive_has_gps_location(current_dive))
+ // zoomOutForNoGPS();
}
void GlobeGPS::changeDiveGeoPosition(qreal lon, qreal lat, GeoDataCoordinates::Unit unit)