diff options
author | Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2020-04-26 18:57:51 +0200 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2020-04-26 13:54:59 -0700 |
commit | 2ad3696230e5bbd4f5a339121812d27e857c1789 (patch) | |
tree | 0075e6a626e441f434aedb7f005adc468ff5c8cd | |
parent | 5d49da5d6b3a16a9f0d08328a5e3dc9b609a1b51 (diff) | |
download | subsurface-2ad3696230e5bbd4f5a339121812d27e857c1789.tar.gz |
cleanup: make DiveListView slots private
It makes reasoning about code so much easier when one knows that
functions cannot be accessed from the outside. Therefore, make
a number of DiveListView slots private. Moreover, unslotize
functions that never were used in connect calls.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
-rw-r--r-- | desktop-widgets/divelistview.h | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/desktop-widgets/divelistview.h b/desktop-widgets/divelistview.h index 9b5d2d7d8..502d0905e 100644 --- a/desktop-widgets/divelistview.h +++ b/desktop-widgets/divelistview.h @@ -28,19 +28,21 @@ public: QList<dive_trip *> selectedTrips(); static QString lastUsedImageDir(); static void updateLastUsedImageDir(const QString &s); + void loadImages(); + void loadWebImages(); signals: void divesSelected(); public slots: - void toggleColumnVisibilityByIndex(); void reloadHeaderActions(); +private +slots: + void toggleColumnVisibilityByIndex(); void sortIndicatorChanged(int index, Qt::SortOrder order); void removeFromTrip(); void deleteDive(); void markDiveInvalid(); void markDiveValid(); - void rowsInserted(const QModelIndex &parent, int start, int end) override; - void reset() override; void mergeTripAbove(); void mergeTripBelow(); void newTripAbove(); @@ -50,12 +52,12 @@ slots: void splitDives(); void renumberDives(); void shiftTimes(); - void loadImages(); - void loadWebImages(); void diveSelectionChanged(const QVector<QModelIndex> &indices); void currentDiveChanged(QModelIndex index); void tripChanged(dive_trip *trip, TripField); private: + void rowsInserted(const QModelIndex &parent, int start, int end) override; + void reset() override; void setSelection(const QRect &rect, QItemSelectionModel::SelectionFlags flags) override; void unselectDives(); void mouseReleaseEvent(QMouseEvent *event) override; |